| Summary: | sys-devel/make: glob speedups from upstream | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Tomáš Chvátal (RETIRED) <scarabeus> |
| Component: | New packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 383311 | ||
| Bug Blocks: | |||
| Attachments: | glob-speedup.patch | ||
what are the actual upstream commits ? i see only: http://cvs.savannah.gnu.org/viewvc/make/read.c?root=make&r1=1.198&r2=1.199 This attached diff is larger due to whitespace change for that case, otherwise they are both same, feel free to pick the one from upstream directly, obviously nobody bothered to rebase it at libreo repository :) nm. upstream viewvc ignores whitespace differences when showing patches. should be all set now in the tree; thanks for the report! Commit message: Add glob optimization patch from upstream http://sources.gentoo.org/sys-devel/make/files/make-3.82-glob-speedup.patch?rev=1.1 http://sources.gentoo.org/sys-devel/make/make-3.82-r2.ebuild?rev=1.1 ive punted that version. it breaks things like busybox. This seems to prove, that while picking up changes from upstream repos, it's good to read some of the following commits: http://cvs.savannah.gnu.org/viewvc/make/read.c?root=make&r1=1.199&r2=1.200 The most amusing part of it is that the patch in comment 0 already included this change. it said in the patch that it is r198 to r200 :) I am reopening this as I will try to find out wtf went wrong (we really plan to rely on this stuff, so i need it for openSUSE at minimal (I will run tinderbox test in next few days for it). the built in bugzilla viewvc browser trims metadata should be all set now in the tree; thanks for the report! Commit message: Add more complete glob optimization patch from upstream http://sources.gentoo.org/sys-devel/make/files/make-3.82-glob-speedup.patch?rev=1.1 http://sources.gentoo.org/sys-devel/make/make-3.82-r3.ebuild?rev=1.1 |
Created attachment 286365 [details, diff] glob-speedup.patch Hi, this patch from upstream speeds up globbing function by not actually doing it when it is not needed. Thus saving some precious cycles. In libreoffice you get 60-20 secs speedups in avg. See the attached patch from upstream repo.