Summary: | mail-mta/exim-4.76 uses deprecated --oknodo of start-stop-daemon | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Marcel Pennewiß <gentoo> |
Component: | Current packages | Assignee: | Fabian Groffen <grobian> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | idl0r, misc, net-mail+disabled |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 377843 | ||
Attachments: | exim.rc6.patch |
Description
Marcel Pennewiß
2011-06-23 10:30:45 UTC
JFYI: deprecation message was added in sys-apps/openrc-0.8.3 Created attachment 278621 [details, diff]
exim.rc6.patch
fix for init-script in files-directory
hmmm, and this does the same? (--stop argument is removed as well?) exactly, see start-stop-daemon.c: ... /* Allow start-stop-daemon --signal HUP --exec /usr/sbin/dnsmasq * instead of forcing --stop --oknodo as well */ if (!start && !stop && sig != SIGINT && sig != SIGTERM && sig != SIGQUIT && sig != SIGKILL) oknodo = true; ... --stop has not been removed its just useless/not what you want in this case. Also the --quiet seems to be not necessary here. start-stop-daemon --signal HUP --pidfile /var/run/exim.pid --name exim That should be enough. idl0r, if you are confident about the change, could you please fix it for me? (In reply to comment #6) > idl0r, if you are confident about the change, could you please fix it for me? Hm, that will break compatibility to baselayout1. Either we wait until its officially deprecated/obsolete or I patch it anyway. Please ping me in IRC when you're online :P I think it would ok to implement this in 4.76-r1 (probably with revbump, I unfortunately forgot about this bug yesterday :( ), exim.rc7 that is. Would you care to commit the necessary changes? (In reply to comment #8) > I think it would ok to implement this in 4.76-r1 (probably with revbump, I > unfortunately forgot about this bug yesterday :( ), exim.rc7 that is. > > Would you care to commit the necessary changes? Done. thanks, looks fixed to me then. Re-emerge -r1 if you want/need this change and are on ~arch |