Summary: | gnome-extra/gnome-color-manager ebuild request | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Andrey Ovcharov <sudormrfhalt> |
Component: | [OLD] GNOME | Assignee: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | anm.mlist01, dabbott, gnome, inspirra, jlec, serge |
Priority: | Low | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://projects.gnome.org/gnome-color-manager/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
gnome-extra/gnome-color-manager/gnome-color-manager-2.29.1.ebuild
gnome-extra/gnome-color-manager-2.29.1.ebuild |
Description
Andrey Ovcharov
2009-11-03 09:12:10 UTC
Created attachment 212535 [details]
gnome-extra/gnome-color-manager/gnome-color-manager-2.29.1.ebuild
Created attachment 214265 [details]
gnome-extra/gnome-color-manager-2.29.1.ebuild
Corrected dependencies
# CC gcm_import-gcm-import.o # In file included from /usr/include/unique-1.0/unique/uniqueapp.h:27, # from /usr/include/unique-1.0/unique/unique.h:24, # from gcm-prefs.c:27: # /usr/include/gtk-2.0/gtk/gtkwindow.h:28:2: error: #error "Only <gtk/gtk.h> can be included directly." # In file included from /usr/include/unique-1.0/unique/uniquebackend.h:26, # from /usr/include/unique-1.0/unique/unique.h:25, # from gcm-prefs.c:27: # /usr/include/gtk-2.0/gdk/gdkscreen.h:25:2: error: #error "Only <gdk/gdk.h> can be included directly." # make[3]: *** [gcm_prefs-gcm-prefs.o] Error 1 build.log: http://pastebin.ca/1737991 emere --info: http://pastebin.ca/1737995 (In reply to comment #4) > # > CC gcm_import-gcm-import.o > # > In file included from /usr/include/unique-1.0/unique/uniqueapp.h:27, > # > from /usr/include/unique-1.0/unique/unique.h:24, > # > from gcm-prefs.c:27: > # > /usr/include/gtk-2.0/gtk/gtkwindow.h:28:2: error: #error "Only <gtk/gtk.h> can > be included directly." > # > In file included from /usr/include/unique-1.0/unique/uniquebackend.h:26, > # > from /usr/include/unique-1.0/unique/unique.h:25, > # > from gcm-prefs.c:27: > # > /usr/include/gtk-2.0/gdk/gdkscreen.h:25:2: error: #error "Only <gdk/gdk.h> can > be included directly." > # > make[3]: *** [gcm_prefs-gcm-prefs.o] Error 1 > > > build.log: http://pastebin.ca/1737991 > emere --info: http://pastebin.ca/1737995 > The fix is pretty simple to write, apparently gcm-prefs.c includes gtkwindow.h directly which is bad (if some headers are renamed due to an API change for example), you've just to replace it by a : #include <gtk/gtk.h> same thing for gdkscreen.h (replace it by gdk/gdk.h) :) updating libunique to 1.1.x fixes the problem We should bump this into gnome overlay for testing. Gnome-color-manager is now listed into default gnome application. Lastest version is 2.31.6. I'm interested in this myself, I picked up the ebuild and reworked it a bit, but there is an automagic dep on sane that will require met o patch it before pushing it anywhere. for the record, there is an ebuild for 2.32 in the gnome overlay. I forgot to update this report afterwards. Ah fun — I found the commit upstream used to make sane optional though and it's not nice. Gnome team, any misgiving if I were to import this into maintree? nope, it's fine, you can add us a backup herd if you wish. In tree now :) What about ~x86? |