Summary: | >=gnome-extra/gnome-screensaver-2.26.1 ignores "gnome-screensaver-command -p" | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | peng shao <shallpion> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED UPSTREAM | ||
Severity: | normal | CC: | bgreen0, bugzilla-gentoo, media-video, netbox253, pacho, poncho |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
URL: | https://bugzilla.gnome.org/show_bug.cgi?id=579430 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 263083 | ||
Attachments: |
patch I found for ubuntu gnome-screensaver-2.28.0
10_legacy_scrsvr_inhibit.patch Reintroduce legacy API for inhibiting the screensaver |
Description
peng shao
2009-10-12 09:44:07 UTC
Created attachment 206847 [details]
patch I found for ubuntu gnome-screensaver-2.28.0
This patch did not work for me, but perhaps you are willing to test it by yourselves because I might have made any stupid mistakes. Thanks. I did not check the box for patch, because it is not a confirmed patch sorry for that.
I don't think you are imagining the occasional missing of idle timeouts. I'm seeing the same thing on a couple systems with gnome-screensaver-2.26.1. Bug 295227 seems related to that issue. Looks similar to: https://bugzilla.gnome.org/show_bug.cgi?id=579430 Created attachment 215154 [details, diff]
10_legacy_scrsvr_inhibit.patch
This is the patch currently used by ubuntu, but it hasn't been accepted by upstream yet :-/
(In reply to comment #4) > Created an attachment (id=215154) [details] > 10_legacy_scrsvr_inhibit.patch > > This is the patch currently used by ubuntu, but it hasn't been accepted by > upstream yet :-/ > Thank you guys :) I will test the patch I could not see any difference from the debug information after I applied the patch... (In reply to comment #6) > I could not see any difference from the debug information after I applied the > patch... > And, is screensaver still being activated when viewing a movie with mplayer/vlc and trying to prevent it running gnome-screensaver -p ? (seems that it's the effect seen by people suffering this removal during 2.24 -> 2.26 update) (In reply to comment #7) > (In reply to comment #6) > > I could not see any difference from the debug information after I applied the > > patch... > > > > And, is screensaver still being activated when viewing a movie with mplayer/vlc > and trying to prevent it running gnome-screensaver -p ? (seems that it's the > effect seen by people suffering this removal during 2.24 -> 2.26 update) > I did several tests from mplayer and with a sleep command, and by now it seems to be working like a charm, and very unlikely it would fall into trouble again. I looked into the discussion of gnome bugzilla and it looks like this patch is only a workaround since it is not the original way gnome-screensaver to realize the poke, isn't it? At least it could not give the expected debug information. I don't know when the mainstream will accept it and even if they will accept it at all, but it is working for end-users. (In reply to comment #8) > I looked into the discussion of gnome bugzilla and it looks like this patch is > only a workaround since it is not the original way gnome-screensaver to realize > the poke, isn't it? At least it could not give the expected debug information. This is what I suspected :-) > I don't know when the mainstream will accept it and even if they will accept it > at all, but it is working for end-users. > OK FYI, seems that this was the (huge) commit that changed this: http://git.gnome.org/browse/gnome-screensaver/commit/?id=403d9bed54d705253ffe5e8c8874ce97cd557d19 https://bugzilla.gnome.org/show_bug.cgi?id=444927 then, probably vlc /mplayer should be fixed instead :-/ (In reply to comment #10) > FYI, seems that this was the (huge) commit that changed this: > http://git.gnome.org/browse/gnome-screensaver/commit/?id=403d9bed54d705253ffe5e8c8874ce97cd557d19 > https://bugzilla.gnome.org/show_bug.cgi?id=444927 > > then, probably vlc /mplayer should be fixed instead :-/ > Hmmm, too scary for me. Looks like I have to wait for further news because now I am totally lost in this jungle of codes....And being frank if my memory serves well mplayer has a long time trouble with the screensaver :( (In reply to comment #10) > then, probably vlc /mplayer should be fixed instead :-/ > after searching a bit more, seems that mplayer should work with gnome-screensaver without needing to use gnome-screensaver-command -p (and a xorg-server >1.4): https://bugzilla.gnome.org/show_bug.cgi?id=552209#c1 http://www.libsdl.org/cgi/viewvc.cgi?revision=3558&view=revision (the interesting link is http://svn.mplayerhq.hu/mplayer?view=rev&revision=25637 , but it doesn't work now). Then, if you still needs to use gnome-screensaver-command -p with recent mplayers, I think that it's a different bug (In reply to comment #12) > (In reply to comment #10) > > then, probably vlc /mplayer should be fixed instead :-/ > > > > after searching a bit more, seems that mplayer should work with > gnome-screensaver without needing to use gnome-screensaver-command -p (and a > xorg-server >1.4): > https://bugzilla.gnome.org/show_bug.cgi?id=552209#c1 > http://www.libsdl.org/cgi/viewvc.cgi?revision=3558&view=revision (the > interesting link is http://svn.mplayerhq.hu/mplayer?view=rev&revision=25637 , > but it doesn't work now). Then, if you still needs to use > gnome-screensaver-command -p with recent mplayers, I think that it's a > different bug > I tried to remove the heart-beat command from mplayer and apparently it could not stop screensaver from launching. :( Video herd, can you please take a look on comment #12 and #13 and tell us if mplater should work or not without needing to run "gnome-screensaver -p"? Thanks a lot We cannot do much more since commented patch causes other kind of problems and this needs to be handled by upstream directly. Sorry for the inconvenience *** Bug 352997 has been marked as a duplicate of this bug. *** (In reply to comment #15) > We cannot do much more since commented patch causes other kind of problems and > this needs to be handled by upstream directly. > > Sorry for the inconvenience > New patch from https://bugzilla.gnome.org/show_bug.cgi?id=579430 This patch fixes the gnome-screensaver activation in combination with vlc. Created attachment 261709 [details, diff]
Reintroduce legacy API for inhibiting the screensaver
@poncho, we are not going to apply this patch, cf. upstream bug report. |