Summary: | gnome-base/libgnomekbd-2.26.0 fails to compile with x11-libs/libxklavier-4.0 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alexandre Rostovtsev (RETIRED) <tetromino> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | a, anm.mlist01, cbm, deduktionstheorem, jlec, joost.ruis, n-roeser, sajes15 |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
libgnomekbd-2.26.0-libxklavier-4.0.patch
libgnomekbd-2.26.0.ebuild.diff libgnomekbd-2.26.0-libxklavier-4.0-supports.patch libgnomekbd-2.26.0.ebuild.diff gnome-control-center-2.26.0-libxklavier-4.0-supports.patch Log |
Description
Alexandre Rostovtsev (RETIRED)
2009-07-20 02:45:21 UTC
also fail: gnome-base/gdm-2.26.1 gnome-base/gnome-control-center-2.26.0 with similar errors. The patch is here: http://www.openmamba.org/showfile.html?file=/pub/openmamba/devel/patches/libgnomekbd-2.26.0-libxklavier-4.0.patch Created attachment 198524 [details, diff] libgnomekbd-2.26.0-libxklavier-4.0.patch Patch from comment #2 Created attachment 198527 [details, diff]
libgnomekbd-2.26.0.ebuild.diff
Ebuild change to apply patch.
Created attachment 198542 [details, diff]
libgnomekbd-2.26.0-libxklavier-4.0-supports.patch
Update the patch by optional loading of extras from upstream,gnome-control-center-2.26.0 also needed.
Created attachment 198544 [details, diff]
libgnomekbd-2.26.0.ebuild.diff
Created attachment 198547 [details, diff] gnome-control-center-2.26.0-libxklavier-4.0-supports.patch (In reply to comment #1) > also fail: > gnome-base/gdm-2.26.1 > gnome-base/gnome-control-center-2.26.0 > with similar errors. > The patch for gnome-control-center-2.26.0 libxklavier-4.0 support. I guess I can confirm this, I'll attach my log. Created attachment 198551 [details]
Log
It would be nicer if those patch could handle both pre libxklavier-4 and libxklavier 4. Otherwise we will have to be careful when stabilizing. Comment on attachment 198524 [details, diff]
libgnomekbd-2.26.0-libxklavier-4.0.patch
Simple and competent
Comment on attachment 198547 [details, diff]
gnome-control-center-2.26.0-libxklavier-4.0-supports.patch
--- gnome-control-center-2.26.0.orig/capplets/keyboard/gnome-keyboard-properties-xkb.c 2008-11-05 00:09:47.000000000 +0800
+++ gnome-control-center-2.26.0/capplets/keyboard/gnome-keyboard-properties-xkb.c 2009-07-20 19:11:53.000000000 +0800
@@ -155,7 +155,7 @@
engine = xkl_engine_get_instance (GDK_DISPLAY ());
config_registry = xkl_config_registry_get_instance (engine);
- xkl_config_registry_load (config_registry);
+ xkl_config_registry_load (config_registry,FALSE);
gkbd_keyboard_config_init (&initial_config, xkb_gconf_client,
engine);
wait, if upstream already commited a patch, we will take this one if possible, and avoid ourselves the pain of having a less functional patch. (In reply to comment #13) > wait, if upstream already commited a patch, we will take this one if possible, > and avoid ourselves the pain of having a less functional patch. > http://mail.gnome.org/archives/gnome-announce-list/2009-June/msg00059.html Apparently,that new feature is unnecessary for current gnome-2.26. it just says 2.26 can't use it, it doesn't mean the patch with the gconf changes doesn't make it immediately useful for 2.26 (which I think it does). Same patch used in Fedora 2.27.4, http://cvs.fedoraproject.org/viewvc/rpms/libgnomekbd/devel/libxklavier4.patch?view=markup Fixed and kept compatibility with older libxklavier. Thanks for reporting and pointing to patches. |