Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 278367 - gnome-base/libgnomekbd-2.26.0 fails to compile with x11-libs/libxklavier-4.0
Summary: gnome-base/libgnomekbd-2.26.0 fails to compile with x11-libs/libxklavier-4.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-20 02:45 UTC by Alexandre Rostovtsev (RETIRED)
Modified: 2009-07-20 22:25 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libgnomekbd-2.26.0-libxklavier-4.0.patch (libgnomekbd-2.26.0-libxklavier-4.0.patch,431 bytes, patch)
2009-07-20 05:59 UTC, LeonBernieniv
Details | Diff
libgnomekbd-2.26.0.ebuild.diff (libgnomekbd-2.26.0.ebuild.diff,833 bytes, patch)
2009-07-20 06:01 UTC, LeonBernieniv
Details | Diff
libgnomekbd-2.26.0-libxklavier-4.0-supports.patch (libgnomekbd-2.26.0-libxklavier-4.0-supports.patch,4.17 KB, patch)
2009-07-20 07:26 UTC, LeonBernieniv
Details | Diff
libgnomekbd-2.26.0.ebuild.diff (libgnomekbd-2.26.0.ebuild.diff,842 bytes, patch)
2009-07-20 07:30 UTC, LeonBernieniv
Details | Diff
gnome-control-center-2.26.0-libxklavier-4.0-supports.patch (gnome-control-center-2.26.0-libxklavier-4.0.patch,9.46 KB, patch)
2009-07-20 07:54 UTC, LeonBernieniv
Details | Diff
Log (log.txt,18.23 KB, text/plain)
2009-07-20 08:12 UTC, Joost Ruis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Rostovtsev (RETIRED) gentoo-dev 2009-07-20 02:45:21 UTC
After installing libxklavier-4.0 :

# emerge libgnomekbd
[...]
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I.. -Wall -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DORBIT2=1 -pthread -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2 -I../intl -DSYS_PLUGIN_DIR=\"/usr/lib64/gnomekbd/\" -DG_LOG_DOMAIN=\"GnomeKbdIndicator\" -DGLADEDIR=\"\" -DDATADIR=\"/usr/share\" -DSYSCONFDIR=\"/etc\" -DLIBDIR=\"/usr/lib64\" -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -march=native -O2 -pipe -MT libgnomekbdui_la-gkbd-indicator.lo -MD -MP -MF .deps/libgnomekbdui_la-gkbd-indicator.Tpo -c gkbd-indicator.c  -fPIC -DPIC -o .libs/libgnomekbdui_la-gkbd-indicator.o
gkbd-indicator.c: In function 'gkbd_indicator_global_init':
gkbd-indicator.c:720: error: too few arguments to function 'xkl_config_registry_load'
make[3]: *** [libgnomekbdui_la-gkbd-indicator.lo] Error 1
make[3]: Leaving directory `/var/tmp/portage/gnome-base/libgnomekbd-2.26.0/work/libgnomekbd-2.26.0/libgnomekbd'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/var/tmp/portage/gnome-base/libgnomekbd-2.26.0/work/libgnomekbd-2.26.0/libgnomekbd'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/gnome-base/libgnomekbd-2.26.0/work/libgnomekbd-2.26.0'
make: *** [all] Error 2
 * 
 * ERROR: gnome-base/libgnomekbd-2.26.0 failed.
Comment 1 Colin Macdonald 2009-07-20 05:12:47 UTC
also fail:
  gnome-base/gdm-2.26.1
  gnome-base/gnome-control-center-2.26.0 
with similar errors.
Comment 3 LeonBernieniv 2009-07-20 05:59:23 UTC
Created attachment 198524 [details, diff]
libgnomekbd-2.26.0-libxklavier-4.0.patch

Patch from comment #2
Comment 4 LeonBernieniv 2009-07-20 06:01:12 UTC
Created attachment 198527 [details, diff]
libgnomekbd-2.26.0.ebuild.diff

Ebuild change to apply patch.
Comment 5 LeonBernieniv 2009-07-20 07:26:44 UTC
Created attachment 198542 [details, diff]
libgnomekbd-2.26.0-libxklavier-4.0-supports.patch

Update the patch by optional loading of extras from upstream,gnome-control-center-2.26.0 also needed.
Comment 6 LeonBernieniv 2009-07-20 07:30:23 UTC
Created attachment 198544 [details, diff]
libgnomekbd-2.26.0.ebuild.diff
Comment 7 LeonBernieniv 2009-07-20 07:54:54 UTC
Created attachment 198547 [details, diff]
gnome-control-center-2.26.0-libxklavier-4.0-supports.patch

(In reply to comment #1)
> also fail:
>   gnome-base/gdm-2.26.1
>   gnome-base/gnome-control-center-2.26.0 
> with similar errors.
> 

The patch for gnome-control-center-2.26.0 libxklavier-4.0 support.
Comment 8 Joost Ruis 2009-07-20 08:12:09 UTC
I guess I can confirm this, I'll attach my log.
Comment 9 Joost Ruis 2009-07-20 08:12:43 UTC
Created attachment 198551 [details]
Log
Comment 10 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-07-20 09:29:28 UTC
It would be nicer if those patch could handle both pre libxklavier-4 and libxklavier 4. Otherwise we will have to be careful when stabilizing.
Comment 11 LeonBernieniv 2009-07-20 12:34:48 UTC
Comment on attachment 198524 [details, diff]
libgnomekbd-2.26.0-libxklavier-4.0.patch

Simple and competent
Comment 12 LeonBernieniv 2009-07-20 12:38:40 UTC
Comment on attachment 198547 [details, diff]
gnome-control-center-2.26.0-libxklavier-4.0-supports.patch

--- gnome-control-center-2.26.0.orig/capplets/keyboard/gnome-keyboard-properties-xkb.c	2008-11-05 00:09:47.000000000 +0800
+++ gnome-control-center-2.26.0/capplets/keyboard/gnome-keyboard-properties-xkb.c	2009-07-20 19:11:53.000000000 +0800
@@ -155,7 +155,7 @@
 
 	engine = xkl_engine_get_instance (GDK_DISPLAY ());
 	config_registry = xkl_config_registry_get_instance (engine);
-	xkl_config_registry_load (config_registry);
+	xkl_config_registry_load (config_registry,FALSE);
 
 	gkbd_keyboard_config_init (&initial_config, xkb_gconf_client,
 				   engine);
Comment 13 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-07-20 12:51:44 UTC
wait, if upstream already commited a patch, we will take this one if possible, and avoid ourselves the pain of having a less functional patch.
Comment 14 LeonBernieniv 2009-07-20 14:10:58 UTC
(In reply to comment #13)
> wait, if upstream already commited a patch, we will take this one if possible,
> and avoid ourselves the pain of having a less functional patch.
> 

http://mail.gnome.org/archives/gnome-announce-list/2009-June/msg00059.html
Apparently,that new feature is unnecessary for current gnome-2.26.
Comment 15 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-07-20 14:22:22 UTC
it just says 2.26 can't use it, it doesn't mean the patch with the gconf changes doesn't make it immediately useful for 2.26 (which I think it does).
Comment 16 Samuli Suominen (RETIRED) gentoo-dev 2009-07-20 21:28:30 UTC
Same patch used in Fedora 2.27.4,

http://cvs.fedoraproject.org/viewvc/rpms/libgnomekbd/devel/libxklavier4.patch?view=markup
Comment 17 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-07-20 22:25:33 UTC
Fixed and kept compatibility with older libxklavier. Thanks for reporting and
pointing to patches.