Summary: | media-video/kaffeine-0.8.7-r1 USE=-dvb EAPI-2 horkage [patch] | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Duncan <1i5t5.duncan> |
Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | InVCS |
Priority: | High | ||
Version: | 2008.0 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge --info
emerge log kaffeine eapi2 & /usr/kde/ mv patch |
Description
Duncan
2009-05-13 12:46:37 UTC
Created attachment 191143 [details]
emerge --info
Created attachment 191145 [details]
emerge log
This is (I think) the log with the "simple flags" env file mentioned above activated. Here's the emerge -av1 prompt, showing USE=-dvb
[ebuild R ] media-video/kaffeine-0.8.7-r1 USE="encode vorbis xcb xinerama -debug -dvb -gstreamer" 0 kB
Note again the .configure line (not turning off dvb, despite the ebuild myconf), the configure results summary (DVB support enabled), and that the failure was in the dvb subdirs, which it shouldn't be building anyway, according to the USE flag, but will, according to the configure summary.
I tried downgrading autoconf to 2.63, which is what I had when I did the successful February kaffeine merge, no change. So eclasses? Nailed to kde.eclass, the May 12 changes, revision 1.223. Substituting in 1.222, the config summary correctly states DVB no, with the current 1.223, it incorrectly states DVB yes. D'oh. Simple enough fix. When the ebuild claims to be EAPI-2, make it so -- split the src_compile accordingly. In this case, it's all configure, so rename the function to src_configure, and at the end, call kde_src_configure instead of kde_src_compile. The compile is then handed automatically Two-line change: -- kaffeine-0.8.7-r1.ebuild 2009-04-12 01:07:53.000000000 -0700 +++ /tmp/kaffeine-0.8.7-r1.ebuild 2009-05-13 10:12:59.000000000 -0700 @@ -46,7 +46,7 @@ src_prepare() { : } -src_compile() { +src_configure() { # see bug #143168 replace-flags -O3 -O2 @@ -63,7 +63,7 @@ src_compile() { $(use_with xcb) $(use_with encode lame)" - kde_src_compile + kde_src_configure } src_install() { Created attachment 191183 [details, diff] kaffeine eapi2 & /usr/kde/ mv patch OK, the patch in comment #5 fixed the EAPI-2 horkage, but the recent kdelibs update moved most kde-3.5 package files from /usr to /usr/kde/3.5, and the ebuild had the old location hard-coded in a couple places, so it was still breaking. Namely, the l10n/mofile fix was breaking, as was the removal of the mplayer desktop file, both at the end of the install phase. This patch should fix those too, and at least here, I get a successful merge, now. This obsoletes the patch in the comment above. replace /usr/kde/3.5 for ${KDEDIR} otherwise patch looks good for applying. Thx for patch. Applied. |