Summary: | app-arch/p7zip version bump to 4.65 including new GUI | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Justin Lecher (RETIRED) <jlec> |
Component: | New packages | Assignee: | Radoslaw Stachowiak (RETIRED) <radek> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | acheron, chithanh, sergey.dryabzhinsky |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://sourceforge.net/projects/p7zip/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
p7zip-4.61.ebuild.patch
files/4.61-makefile.patch /mnt/tmpfs/p7zip-4.61-r1.ebuild.diff p7zip-4.58-to-4.61.ebuild.diff app-arch/p7zip/p7zip-4.61.ebuild Makefile patch no longer needed, RAR decompression support Changed license for RAR decompressor Makefile patch no longer needed, RAR decompression support, unRAR license Makefile patch no longer needed, RAR decompression support, unRAR license |
Description
Justin Lecher (RETIRED)
2008-12-04 10:38:05 UTC
Created attachment 174218 [details]
p7zip-4.61.ebuild.patch
patch
Created attachment 174220 [details]
files/4.61-makefile.patch
makefile.patch
wxGTK dependencies aren't so easy on EAPI=0, you should probably want to use EAPI=2 and wxGTK[X], and it should be dependent on X USE flag I guess, unless they used wxBase for other stuff too, in which case it should probably be wxGTK[X?]. Of course you are right. Didn't notice the X USE on wxGTK, as I thought widgets always need X. K, I update for that. Thanks for pointing me on that. Created attachment 174258 [details]
/mnt/tmpfs/p7zip-4.61-r1.ebuild.diff
EAPI="2" version as Diego suggested.
Is EAPI2 supported in portage-2.1.6?
(In reply to comment #5) > Created an attachment (id=174258) [edit] > /mnt/tmpfs/p7zip-4.61-r1.ebuild.diff > > EAPI="2" version as Diego suggested. > > Is EAPI2 supported in portage-2.1.6? > Replying in the interests of keeping this ticket alive; yes. Maybe the 'X' flag shoud be changed to 'wxwindows' like in other ebuilds? Oh, and I think there should be no hard dep: RDEPEND="X? ( x11-libs/wxGTK[X] )" # EAPI=2 (In reply to comment #8) > Oh, and I think there should be no hard dep: > > RDEPEND="X? ( x11-libs/wxGTK[X] )" # EAPI=2 > Yiep, right. Created attachment 177604 [details, diff]
p7zip-4.58-to-4.61.ebuild.diff
Based on 4.61-r1 and latest 4.58 from portage, with EAPI=2 and USE-flag 'wxwindows'
Created attachment 181493 [details]
app-arch/p7zip/p7zip-4.61.ebuild
4.65 is out Created attachment 187961 [details]
Makefile patch no longer needed, RAR decompression support
Added "rar" USE flag to enable non-free RAR decoder.
Changed sed command in src_prepare() so that it affects only compilation flags, but not creating the symlinks.
Tested with p7zip-4.65 on AMD64.
You have to somehow adopt the license then. What do you mean "adopt the license"? Change the license in the ebuild? I'll do that. The ebuild should ask the user if he accepts the unrar license? What is the best way to do that? (In reply to comment #15) > What do you mean "adopt the license"? > > Change the license in the ebuild? I'll do that. > > The ebuild should ask the user if he accepts the unrar license? What is the > best way to do that? > This is something we must think about ( and better query some devs ). I just wanted to remind that there is only the free license in the ebuild. Perhaps it is enough to set LICENSE="|| ( GPL-2 NONFREELICENSE )" > This is something we must think about ( and better query some devs ).
There used to be something like that in app-emulation/virtualbox-bin. It showed the license and then stopped and waited for user to accept or decline it. But it has been removed.
Created attachment 187967 [details]
Changed license for RAR decompressor
Same as before, but with LICENSE="|| ( LGPL-2.1 unRAR )"
I think LICENSE="|| ( LGPL-2.1 unRAR )" is not correct. The resulting package is governed both by LGPL-3 and unRAR licenses and not one of them according to the user's choice. If the user sets USE="-rar", the resulting license is exactly LGPL. If the user sets USE="rar", the resulting license is LGPL with additional unrar restrictions (to put it simply: "Do not reverse engineer the compression algorithm; do not sell the decompressor without the written permission"). What should it be? LICENSE="|| ( LGPL-2.1 unRAR+LGPL-2.1 )" ? (In reply to comment #20) > If the user sets USE="-rar", the resulting license is exactly LGPL. If the user > sets USE="rar", the resulting license is LGPL with additional unrar > restrictions (to put it simply: "Do not reverse engineer the compression > algorithm; do not sell the decompressor without the written permission"). > > What should it be? LICENSE="|| ( LGPL-2.1 unRAR+LGPL-2.1 )" ? > right syntax would be: LICENSE="rar? ( LGPL-2.1 unRAR ) !rar? ( LGPL-2.1 )" LICENSE="LGPL-2.1 rar? ( unRAR )" would also be ok Created attachment 189254 [details]
Makefile patch no longer needed, RAR decompression support, unRAR license
Changed LICENSE to "LGPL-2.1 rar? ( unRAR )"
If I have time the next days and the maintainer doesn't shows up or react, I will commit the changes via a proxy maintainer I found. There are still some possible issues with the ebuild: in RDEPEND it should be kde-base/konqueror:3.5 rather than >=kde-base/konqueror:3.5 the next line should read DEPEND="${RDEPEND}" not RDEPENDS This is the latest version I use http://gentoo.j-schmitz.net/portage/ebuilds/app-arch/p7zip/p7zip-4.65.ebuild Created attachment 189361 [details] Makefile patch no longer needed, RAR decompression support, unRAR license > in RDEPEND it should be kde-base/konqueror:3.5 Corrected. By the way, it looks like it should work in KDE 4. Maybe that should be reflected in the dependencies? > the next line should read DEPEND="${RDEPEND}" Corrected. +*p7zip-4.65 (26 Apr 2009) + + 26 Apr 2009; Patrick Lauer <patrick@gentoo.org> + +files/4.65-hardlink.patch, +files/4.65-makefile.patch, metadata.xml, + +p7zip-4.65.ebuild: + Bump to 4.65, closes #249780. Based on the ebuild by jlec, incorporating + changes from Flameeyes, Sergey Dryabzhinsky, Ilya Kashirin, A.C.Heron and + Chi-Thanh Christopher Nguyen. Hope I didn't forget anyone. Please test it a bit to see if everything works as expected :) Ok just slightly adjusted build system for kde4 compilance, it needs more fixing tho. Installing translations and html stuff into lib is not peachy... |