Bug 20776 - mhwaveeditor-1.2.1 (New Package)
|
Bug#:
20776
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: enhancement
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: avenj@gentoo.org
|
Reported By: karl420@comcast.net
|
|
Component: Ebuilds
|
|
|
URL:
|
|
Summary: mhwaveeditor-1.2.1 (New Package)
|
|
Keywords:
|
|
Status Whiteboard:
|
|
Opened: 2003-05-10 23:49 0000
|
I should be able to get to this soon.
Created an attachment (id=11784) [details]
How would I change the ebuild
Since you asked for feedback on gentoo-dev, here is how I would have written
the ebuild:
-# http://www.mtek.chalmers.se/~hjormagn/mhwaveedit-1.2.1.tar.gz
+# $Header: $
I think this line is needed to automatize insertion of headers (devs, correct
me if I'm wrong)
-P=${PN}-${PV/_/}
-S=${WORKDIR}/${P}
Unneeded
-DEPEND="virtual/x11
- gtk2? ( >=x11-libs/gtk+-2.0.0 )
+DEPEND="gtk2? ( >=x11-libs/gtk+-2.0.0 )
virtual/x11 is already a dependancy of gtk+
- ( >=media-libs/libsdl-1.2.3 )
+ sdl? ( >=media-libs/libsdl-1.2.3 )
Important!!
+ use sdl || myconf="${myconf} --without-sdl"
Important!!
- econf ${myconf} || die
+ econf ${myconf}
See `man 5 ebuild'
And a little note: if someone uses alsa (has -oss) and has -sdl in USE, will
not be able to play wavs, and I don't know how to avoid that...
Bye!