Summary: | media-libs/libpng-1.2.21-r2 causes gnome-base/nautilus (and possibly other apps) to fail loading png's | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Pierre Poissinger <pierre.poissinger> |
Component: | [OLD] GNOME | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
libpng: Correct the typo but no more
version 1.2.22 seems to include "-r3" patch -> revert it to to just correct the typo but no more |
Description
Pierre Poissinger
2007-10-11 19:43:29 UTC
I suggest you open a bug in Gnome's bugzilla, you'll probably have more luck there :) Please add gnome@gentoo.org as a CC there. Thanks Thx, will do that this weekend (and resolve this one to upstream when done...) btw, I still hope to find the time to look further in this before going upstream...or i am sure that I will have to wait 2.22 to see a fix for that :-P ) Ok, after recompile of # gnome-base/nautilus # dev-libs/glib # x11-libs/gtk+ # app-text/evince # x11-themes/gnome-themes # x11-themes/gnome-themes-extras # x11-themes/gnome-icon-theme # x11-themes/gtk-engines # x11-libs/pango # gnome-base/gnome-vfs # gnome-base/control-center # gnome-base/gnome-desktop in debug, I was unable to reproduce the problem, then recompile everything back to normal, everything was still fine... I still have no clue of what exactly was broken and resulted in this problem ... but as long as it's working again :-) did you by any chance update libpng in the meantime as well ? Bingo ! At time of the problem, I was running media-libs/libpng-1.2.21-r2 When problem was fixed, I used media-libs/libpng-1.2.21-r3 ==> libpng was the guilty and needed the libpng-1.2.21-null-termination-v2.patch Side note: Since I was curious, I took a look at the patch, and it's not 100% perfect: it actually fix an issue actually not linked to null term but to a wrong copy (obviously a typo) and contains a inefficient chunk. [It's not really a issue, it's just FYI...] I will attach a 1 hunk patch that fix the problem Created attachment 133435 [details, diff]
libpng: Correct the typo but no more
Clean (and IMHO better) libpng patch
Btw, naming should be libpng-1.2.21-pngset-typo (since the bug is more a typo than a missing null term)
reopening to assign to base-system hi base-system, this bug was due to libpng 1.2.12-r2 which is now fixed but reporter has a potential better fix. Please review. Created attachment 133458 [details, diff]
version 1.2.22 seems to include "-r3" patch -> revert it to to just correct the typo but no more
Upstream took the -r3 patch, so I revert this change to avoid these 2 strlen
sounds like libpng-1.2.21-r3 and libpng-1.2.22 are fixed correct - but not really in the correct way :-p if you think the libpng guys are doing something wrong, then send an e-mail here: http://lists.sourceforge.net/mailman/listinfo/png-mng-implement Thanks, I already contacted the maintainer since they should know what they are doing... but from the answer I got, it's not (yet) a win win :-D .... [OTW] One more reason to love Open Source: 2 lines of code = more hours of fun than playing Zelda (on a Wii) without arms... [/OTW] |