Summary: | media-libs/libpng-1.2.21 causes several KDE apps to crash/not start | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | teidakankan |
Component: | [OLD] Library | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jakub, keytoaster, kovid, nbensa, peter.saaf, pierre.poissinger |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 195261 | ||
Attachments: |
emerge info
Altered patch libpng-1.2.21-null-termination.patch Correct the typo but nothing more |
Description
teidakankan
2007-10-05 23:57:05 UTC
Created attachment 132689 [details]
emerge info
add yakuake to the list Not having seen what error you get I can't say if it's the same issue but. bmpx crashes with libpng-1.2.21 with the following message. swany@gentoo ~ $ /usr/libexec/beep-media-player-2-bin ** Message: sm.cc:270: Connection opened, client id is 11c0a80001000119166709100000019680007 ** Message: sm.cc:53: XSMP Version: 1 Revision: 0 ** Message: sm.cc:56: Session manager: GnomeSM ** Message: sm.cc:60: Release: 2.20.0 *** glibc detected *** /usr/libexec/beep-media-player-2-bin: malloc(): memory corruption: 0x088889b8 *** ======= Backtrace: ========= /lib/libc.so.6[0xb6e54a8f] /lib/libc.so.6[0xb6e56d20] /lib/libc.so.6(__libc_malloc+0x90)[0xb6e58410] /usr/lib/libglib-2.0.so.0(g_try_malloc+0x33)[0xb70a6563] /usr/lib/libpng12.so.0(png_malloc+0x3d)[0xb6b5eb7d] Works fine with libpng-1.2.20 It's probably this bug. http://sourceforge.net/mailarchive/forum.php?thread_name=47067C84.7010205%40playstation.sony.com&forum_name=png-mng-implement It will be fixed for 1.2.22. libpng-1.2.21 should probably be masked. thanks for the link, ive added the one-liner fix to 1.2.21-r1 1.2.21-r1 didn't resolve anything here. I'll just wait for 1.2.22. Created attachment 132772 [details, diff]
Altered patch
The attached patch works for me.
Shamelessly copied from the 1.2.21 => 1.2.22beta changes. :D
(In reply to comment #7) > Created an attachment (id=132772) [edit] > Altered patch > > The attached patch works for me. > > Shamelessly copied from the 1.2.21 => 1.2.22beta changes. :D > That fixed it. Many thanks! unfortunately, the mailing list only showed the one change, and libpng doesnt have a public scm for me to check, so i just went with what was on the mailing list ive updated the patch for 1.2.21-r2, thanks *** Bug 195147 has been marked as a duplicate of this bug. *** 1.2.21-r2 still causes crashes for me in several apps, kopete being the most prominent. That patch can't be right. Created attachment 133005 [details, diff]
libpng-1.2.21-null-termination.patch
Looks a bit better and should solve all issues.
I committed this patch as -r3 Created attachment 133460 [details, diff] Correct the typo but nothing more Ok, fall with same bug with nautilus (cf http://bugs.gentoo.org/show_bug.cgi?id=195536) ==> the original patch seems a little bit too paranoid for me: first hunk: strncpy of xxx with strlen(xxx)+1 will set a trailing null, no need to 2 call to strlen second hunk: IMHO, not needed... |