Summary: | x11-libs/vte fails to compile on nls free systems (patch included). | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Yuri Vasilevski (RETIRED) <yvasilev> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | embedded |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
vte-0.11.18-nonls.patch
vte-0.12.2-nonls.patch vte-0.12.2.ebuild.diff vte-0.12.2-nonls.patch |
Description
Yuri Vasilevski (RETIRED)
2006-05-26 10:33:16 UTC
Created attachment 87573 [details, diff]
vte-0.11.18-nonls.patch
Thank you for the report and patch. However, it wouldn't be very useful if we followed this in vte-0.11.x now that 0.12.x releases are out, and, as you have noticed, some of the relevant code has changed. Could you try testing and creating a patch against vte-0.12.2? Note that gettext is now listed in DEPEND, so you may want to create a diff for the ebuild as well. Thanks. Created attachment 88556 [details, diff]
vte-0.12.2-nonls.patch
Patch updated to version 0.12.2
Created attachment 88557 [details, diff]
vte-0.12.2.ebuild.diff
You can also "s/nls? (/elibc_uclibc? (/" in DEPEND, but I think nls more appropriate.
(In reply to comment #4) > You can also "s/nls? (/elibc_uclibc? (/" in DEPEND, but I think nls more > appropriate. The problem I see is that for users with gettext installed, vte would be installed with the i18n components, regardless of the value of the 'nls' flag. Unfortunately the --enable-nls option was removed from glib-gettext.m4 (used in vte's configure.in) a while ago, which would have been a nice way to force the meaning of IUSE=nls. However, if you have tested your patch in a gettext-free system, and it works (ENABLE_NLS remains undefined, the .mo files are not installed and so forth), it would be OK to just remove gettext from DEPEND. What do you think? > vte-0.11.18-nonls.patch
patch looks good to me
Created attachment 88609 [details, diff] vte-0.12.2-nonls.patch (In reply to comment #5) > However, if you have tested your patch in a gettext-free system, and it works > (ENABLE_NLS remains undefined, the .mo files are not installed and so forth), > it would be OK to just remove gettext from DEPEND. What do you think? I updated the 0.12.2 patch to wrap all instances of #include <glib/gi18n-lib.h> in #ifdef ENABLE_NLS, this allows it also to compile fine on glibc based gettext free systems as well as on uclibc ones. So it is now safe to drop sys-devel/gettext from DEPEND and vte will support i18n if and only if gettext is installed. (It is a shame they dropped the --enable-nls option) From my USE=-nls uclibc/glibc chroot's config.h: /* always defined to indicate that i18n is enabled */ /* #undef ENABLE_NLS */ While from my USE=nls glibc chroot's one: /* always defined to indicate that i18n is enabled */ #define ENABLE_NLS 1 Now part of vte-0.12.2 (not revbumped since it affects only a small portion of users and it's not a critical change). Thanks for the contribution :) |