[patch] prevent ksensors from calling hddtemp with multiple params

segfault-workaround.patch (text/plain), 1.78 KB, created by frederic bonnaud on 2006-05-31 06:54:10 UTC

--- src/hdsensorslist.cpp.orig	2006-05-31 15:22:15.000000000 +0200
+++ src/hdsensorslist.cpp	2006-05-31 15:27:08.000000000 +0200
@@ -45,28 +45,29 @@
  if(!getDisks(disks)) return;
 
  ProcessExec proc;
- proc << "hddtemp" << "-q";
- for(QStringList::Iterator it = disks.begin(); it != disks.end(); ++it ) {
+ for(QStringList::Iterator it = disks.begin(); it != disks.end(); ++it ) {   
+   proc.clearArguments() ;
+   proc << "hddtemp" << "-q";
    proc << *it;
+   if(proc.runAndWait()) {
+     double value;
+     QString str;
+     for(QStringList::Iterator it = disks.begin(); it != disks.end(); ++it ) {
+       if(getDiskInfo(proc.getStdoutData(),*it,str,value)) {
+          Sensor *sensor= new Sensor(this);
+          sensor->setType(Sensor::lmTemp);
+          sensor->setName(*it);
+          sensor->setDescription(str);
+          sensor->setValueMax  (40   , Sensor::dgCelsius);
+          sensor->setValueMin  ( 0   , Sensor::dgCelsius);
+          sensor->setValueIdeal(value, Sensor::dgCelsius);
+          sensor->setValue     (value, Sensor::dgCelsius);
+          sensor->readConfig();
+       }
+     }
+  }  
  }
 
- if(proc.runAndWait()) {
-    double value;
-    QString str;
-    for(QStringList::Iterator it = disks.begin(); it != disks.end(); ++it ) {
-      if(getDiskInfo(proc.getStdoutData(),*it,str,value)) {
-         Sensor *sensor= new Sensor(this);
-         sensor->setType(Sensor::lmTemp);
-         sensor->setName(*it);
-         sensor->setDescription(str);
-         sensor->setValueMax  (40   , Sensor::dgCelsius);
-         sensor->setValueMin  ( 0   , Sensor::dgCelsius);
-         sensor->setValueIdeal(value, Sensor::dgCelsius);
-         sensor->setValue     (value, Sensor::dgCelsius);
-         sensor->readConfig();
-      }
-    }
- }
 }
 
 HDSensorsList::~HDSensorsList()