Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 591438 - www-client/firefox-48.0: decrease importance of non supported locales message
Summary: www-client/firefox-48.0: decrease importance of non supported locales message
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-17 09:03 UTC by Pacho Ramos
Modified: 2017-08-31 18:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2016-08-17 09:03:45 UTC
As, by default, ewarn messages are stored in logs, I am now getting this always:
WARN: unpack
Sorry, but firefox-48.0 does not support the es locale
WARN: install
Sorry, but firefox-48.0 does not support the es locale


Apart of the message being duplicated (from two phases), also is not important enough since available locales are shown in advance as USE flags when merging the package, then, I would decrease it's importance to "einfo" and, probably, show it only in unpack phase (also, this is specially useless for cases like this that, parent "es" locale is not available but regional versions like es_ES are :/)

Thanks a lot
Comment 1 Jory A. Pratt gentoo-dev 2017-08-26 17:57:05 UTC
If you feel I have closed your bug and it is still a current issue, please reopen and update it completely. We will not work bugs that have no ebuild in tree any longer or can not be reproduced with a current system.

Thank You for your support and understanding
The Mozilla Team
Comment 2 Pacho Ramos gentoo-dev 2017-08-30 16:41:08 UTC
I still hit this on every update
Comment 3 Ian Stakenvicius (RETIRED) gentoo-dev 2017-08-30 20:03:36 UTC
The message is generated when the locales are actually being installed, which is done via functions in the eclasses.  Converting it to einfo seems fine to me but I don't think ensuring just-one-report is feasible, it's an all-or-nothing thing really.  

Given that it's within the LINGUAS compatibility section of the locale handling functionality, we may drop it entirely in the future.

I've just committed the change from ewarn to einfo.  If this fix isn't sufficient please reopen.
Comment 4 Pacho Ramos gentoo-dev 2017-08-31 10:14:54 UTC
Nice, thanks a lot :)
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-08-31 17:17:20 UTC
I hope you don't mind me abusing this bug to do a little test.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-08-31 17:17:40 UTC
Bug has been referenced in the following commit:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=569a4fa2700ca3435f3fca2d4a035e8a50d22cd2

commit 569a4fa2700ca3435f3fca2d4a035e8a50d22cd2
gpg: Signature made śro, 30 sie 2017, 22:03:14 CEST
gpg:                using DSA key A2C4D5C5A3D795BF11CB1838DAE81A237F0008F0
gpg: Good signature from "Ian Stakenvicius (_AxS_) <axs@gentoo.org>" [unknown]
gpg:                 aka "Ian Stakenvicius <ian@aerobiology.ca>" [unknown]
gpg:                 aka "Ian Stakenvicius <i.stakenvicius@gmail.com>" [unknown]
gpg:                 aka "[jpeg image of size 11602]" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: A2C4 D5C5 A3D7 95BF 11CB  1838 DAE8 1A23 7F00 08F0
Author:     Ian Stakenvicius <axs@gentoo.org>
AuthorDate: Wed Aug 30 21:55:21 2017
Commit:     Ian Stakenvicius <axs@gentoo.org>
CommitDate: Wed Aug 30 22:03:14 2017

    mozlinguas-v2.eclass: reduce ewarn on unsupported locale to einfo
    
    Bug: http://bugs.gentoo.org/591438
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-08-31 18:05:37 UTC
Bug has been referenced in the following commit:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=569a4fa2700ca3435f3fca2d4a035e8a50d22cd2

commit 569a4fa2700ca3435f3fca2d4a035e8a50d22cd2
Author:     Ian Stakenvicius <axs@gentoo.org>
AuthorDate: 2017-08-30 19:55:21 +0000
Commit:     Ian Stakenvicius <axs@gentoo.org>
CommitDate: 2017-08-30 20:03:14 +0000

    mozlinguas-v2.eclass: reduce ewarn on unsupported locale to einfo
    
    Bug: http://bugs.gentoo.org/591438