Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 549926 - sys-libs/e2fsprogs-libs is missing a DEPEND on sys-devel/gettext
Summary: sys-libs/e2fsprogs-libs is missing a DEPEND on sys-devel/gettext
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-20 00:41 UTC by Patrick McLean
Modified: 2015-05-25 10:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,34.53 KB, text/plain)
2015-05-20 22:55 UTC, Patrick McLean 		Details
fix to build with USE=-nls on a system without gettext installed (fix-bug549926.patch,835 bytes, patch)
2015-05-21 13:13 UTC, Anthony Basile 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick McLean gentoo-dev 2015-05-20 00:41:37 UTC 
Configure fails if gettext isn't installed.
Comment 1 Anthony Basile gentoo-dev 2015-05-20 13:03:52 UTC 
(In reply to Patrick McLean from comment #0)
> Configure fails if gettext isn't installed.

All ebuilds on the tree have DEPEND="nls? ( sys-devel/gettext )"  So does the ebuild fail if USE=-nls and gettext is not present?  If that's the case, then this is a bug.
Comment 2 Patrick McLean gentoo-dev 2015-05-20 22:55:08 UTC 
Created attachment 403702 [details]
build.log

Yes, the package fails to build if USE=-nls and gettext is not present.

Attaching a the build.log
Comment 3 SpanKY gentoo-dev 2015-05-21 04:02:56 UTC 
we've specifically attempted to elide the dep.  see the code in src_prepare.
Comment 4 Anthony Basile gentoo-dev 2015-05-21 12:44:25 UTC 
You need to also remove intl from the SUBDIRs in Makefile.in (which is really a Makefile.am).  So this patch works:

diff -Naur e2fsprogs-libs-1.42.13.orig/Makefile.in e2fsprogs-libs-1.42.13/Makefile.in
--- e2fsprogs-libs-1.42.13.orig/Makefile.in	2014-08-02 20:26:22.000000000 +0000
+++ e2fsprogs-libs-1.42.13/Makefile.in	2015-05-21 12:43:53.662086288 +0000
@@ -15,7 +15,7 @@
 @BLKID_CMT@BLKID_LIB_SUBDIR= lib/blkid
 QUOTA_LIB_SUBDIR= lib/quota
 
-LIB_SUBDIRS=lib/et lib/ss lib/e2p $(UUID_LIB_SUBDIR) $(BLKID_LIB_SUBDIR) $(QUOTA_LIB_SUBDIR) lib/ext2fs intl
+LIB_SUBDIRS=lib/et lib/ss lib/e2p $(UUID_LIB_SUBDIR) $(BLKID_LIB_SUBDIR) $(QUOTA_LIB_SUBDIR) lib/ext2fs
 PROG_SUBDIRS=e2fsck $(DEBUGFS_DIR) misc $(RESIZE_DIR) tests/progs po
 SUBDIRS=util $(LIB_SUBDIRS) $(PROG_SUBDIRS) tests
 

This is better done as a sed, but this inline patch shows the problem.
Comment 5 Anthony Basile gentoo-dev 2015-05-21 13:13:09 UTC 
Created attachment 403722 [details, diff]
fix to build with USE=-nls on a system without gettext installed

0) This avoids descending into intl/ if USE=-nls.  I tested on a system without gettext and USE=-nls and on a system with gettext with both USE=nls and -nls.

1) I also silence the QA notice about --disable-nls which is a by-product of defining AM_GNU_GETTEXT to be an empty stub.

2) Scratch my parenthetical statement about Makefile.in being an Makefile.am.  It is actually a .in.  Its the configure.in file which should be configure.ac.  Is upstream ever going to change that?  They must be aware by now.