Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 476274 - sci-mathematics/rstudio-0.97.336 fails to build against dev-libs/boost-1.53.0
Summary: sci-mathematics/rstudio-0.97.336 fails to build against dev-libs/boost-1.53.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Julian Ospald
URL: https://github.com/rstudio/rstudio/co...
Whiteboard:
Keywords:
Depends on:
Blocks: boost-1.53
  Show dependency tree
 
Reported: 2013-07-09 12:22 UTC by Bernd Feige
Modified: 2013-07-15 15:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
rstudio-0.97.336-boost_1_53_compat.patch (rstudio-0.97.336-boost_1_53_compat.patch,2.98 KB, patch)
2013-07-09 12:24 UTC, Bernd Feige 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Feige 2013-07-09 12:22:57 UTC 
shared_static_cast must be replaced by static_pointer_cast, cf. upstream commit https://github.com/rstudio/rstudio/commit/d201f53c6077e8e7ecb99652474bf3dd82d9f42c/

Patch is attached.

Reproducible: Always
Comment 1 Bernd Feige 2013-07-09 12:24:18 UTC 
Created attachment 352922 [details, diff]
rstudio-0.97.336-boost_1_53_compat.patch
Comment 2 Julian Ospald 2013-07-14 00:27:20 UTC 
that will break compatibility with old boost, no?
Comment 3 Julian Ospald 2013-07-14 13:33:12 UTC 
brooo?
Comment 4 Bernd Feige 2013-07-15 13:15:32 UTC 
(In reply to Julian Ospald (hasufell) from comment #2)
> that will break compatibility with old boost, no?

Well no, maybe with 0.x versions of boost ;-) We are at boost 1.53 now (1.54 being current), and see what was part of 1.35:

http://www.boost.org/doc/libs/1_35_0/boost/shared_ptr.hpp

Saying: "// shared_*_cast names are deprecated. Use *_pointer_cast instead."

Most other software has adapted to this depreciation long ago and therefore runs with "old" (like 1.35) and current versions alike. With the patch, rstudio does as well.
Comment 5 Julian Ospald 2013-07-15 15:22:08 UTC 
+  15 Jul 2013; Julian Ospald <hasufell@gentoo.org> rstudio-0.97.336.ebuild,
+  +files/rstudio-0.97.336-boost-1.53.patch:
+  fix building with boost-1.53 wrt #476274