Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 769761 (CVE-2021-26825) - [GURU] dev-games/godot: Integer overflow (CVE-2021-26825)
Summary: [GURU] dev-games/godot: Integer overflow (CVE-2021-26825)
Status: RESOLVED FIXED
Alias: CVE-2021-26825
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: GURU project
URL: https://github.com/godotengine/godot/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-09 15:37 UTC by Sam James
Modified: 2021-02-11 19:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester gentoo-dev Security 2021-02-09 15:37:06 UTC
Description:
"An integer overflow issue exists in Godot Engine up to v3.2 that can be triggered when loading specially crafted.TGA image files. The vulnerability exists in ImageLoaderTGA::load_image() function at line: const size_t buffer_size = (tga_header.image_width * tga_header.image_height) * pixel_size; The bug leads to Dynamic stack buffer overflow. Depending on the context of the application, attack vector can be local or remote, and can lead to code execution and/or system crash."

See https://github.com/godotengine/godot/pull/45702.

Note that as we don't do GLSAs for GURU, you are fine to close this bug once bumped/patched & cleaned up.
Comment 1 Larry the Git Cow gentoo-dev 2021-02-11 19:27:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=378fd39928de4e862e0859082620e71449457ae7

commit 378fd39928de4e862e0859082620e71449457ae7
Author:     Ross Charles Campbell <rossbridger.cc@gmail.com>
AuthorDate: 2021-02-10 04:58:17 +0000
Commit:     Ross Charles Campbell <rossbridger.cc@gmail.com>
CommitDate: 2021-02-10 05:05:06 +0000

    dev-games/godot: fix CVE-2021-26825
    
    An integer overflow issue exists in Godot Engine up to v3.2 that can
    be triggered when loading specially crafted.TGA image files. The
    vulnerability exists in ImageLoaderTGA::load_image() function at line:
    
    const size_t buffer_size = (tga_header.image_width * tga_header.image_height) * pixel_size;
    
    The bug leads to Dynamic stack buffer overflow. Depending on the
    context of the application, attack vector can be local or remote,
    and can lead to code execution and/or system crash.
    
    Reference: https://nvd.nist.gov/vuln/detail/CVE-2021-26825
    Reference: https://github.com/godotengine/godot/pull/45702
    Closes: https://bugs.gentoo.org/769761
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Ross Charles Campbell <rossbridger.cc@gmail.com>

 .../files/godot-3.2.3-fix-CVE-2021-26825.patch     | 108 +++++++++++++++++++++
 .../{godot-3.2.3.ebuild => godot-3.2.3-r1.ebuild}  |   5 +-
 2 files changed, 112 insertions(+), 1 deletion(-)