Bug 765016 – <dev-python/flask-security-3.4.5: CSRF vulnerability (CVE-2021-21241)

• Status: RESOLVED FIXED
• Product: Gentoo Security

[Description Sam James 2021-01-11 22:05:19 UTC]

CVE text:
"The Python "Flask-Security-Too" package is used for adding security features to your Flask application. It is an is a independently maintained version of Flask-Security based on the 3.0.0 version of Flask-Security. In Flask-Security-Too from version 3.3.0 and before version 3.4.5, the /login and /change endpoints can return the authenticated user's authentication token in response to a GET request. Since GET requests aren't protected with a CSRF token, this could lead to a malicious 3rd party site acquiring the authentication token. Version 3.4.5 and version 4.0.0 are patched. As a workaround, if you aren't using authentication tokens - you can set the SECURITY_TOKEN_MAX_AGE to "0" (seconds) which should make the token unusable."

... which is confusing. Anyway, the URL for this bug has the actual flask-security security advisory, so I guess it affects us.

[Comment 1 Sam James 2021-01-11 22:05:40 UTC]

Please bump to 3.4.5.

[Comment 2 Larry the Git Cow 2021-01-11 23:56:29 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=82176833aacf96541f5af679e03e463667a4ce73

commit 82176833aacf96541f5af679e03e463667a4ce73
Author:     Michał Górny <[e-mail]>
AuthorDate: 2021-01-11 23:43:00 +0000
Commit:     Michał Górny <[e-mail]>
CommitDate: 2021-01-11 23:56:25 +0000

    dev-python/flask-security: Bump to 3.4.5
    
    Bug: https://bugs.gentoo.org/765016
    Signed-off-by: Michał Górny <[e-mail]>

 dev-python/flask-security/Manifest                 |  1 +
 .../flask-security/flask-security-3.4.5.ebuild     | 74 ++++++++++++++++++++++
 2 files changed, 75 insertions(+)

[Comment 3 Sam James 2021-01-12 12:03:07 UTC]

amd64 x86 (ALLARCHES) done

all arches done

[Comment 4 John Helmert III 2021-01-12 14:13:33 UTC]

Please cleanup.

[Comment 5 John Helmert III 2021-07-24 05:53:52 UTC]

Done in March:

commit 5eb38e39bb838415ba4cd33ce58fbfc7ba44a1dc
Author: Michał Górny <[e-mail]>
Date:   Tue Mar 2 09:51:29 2021 +0100

    dev-python/flask-security: Remove old

    Signed-off-by: Michał Górny <[e-mail]>

 delete mode 100644 dev-python/flask-security/files/flask-security-3.4.3-optional-deps.patch
 delete mode 100644 dev-python/flask-security/flask-security-3.4.4.ebuild
 delete mode 100644 dev-python/flask-security/flask-security-3.4.5.ebuild

All done!