Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 545034 (CVE-2015-6674) - <net-irc/inspircd-2.0.20: two vulnerabilities (CVE-2012-6697,CVE-2015-6674)
Summary: <net-irc/inspircd-2.0.20: two vulnerabilities (CVE-2012-6697,CVE-2015-6674)
Status: RESOLVED FIXED
Alias: CVE-2015-6674
Product: Gentoo Security
Classification: Unclassified
Component: Vulnerabilities (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Security
URL: http://www.openwall.com/lists/oss-sec...
Whiteboard: B2 [glsa cve]
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-30 08:08 UTC by Agostino Sarubbo
Modified: 2015-12-30 21:28 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
InspIRCd 2.0.20 version of fix-path-builds (inspircd-2.0.20-fix-path-builds.patch,7.16 KB, patch)
2015-07-27 10:41 UTC, A. Wilcox (awilfox)
no flags Details | Diff
2.0.20 ebuild (inspircd-2.0.20.ebuild,2.89 KB, text/plain)
2015-09-10 12:17 UTC, A. Wilcox (awilfox)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2015-03-30 08:08:19 UTC
From ${URL} :

the Debian Security Team is requesting 2 CVEs for inspircd.

  * the fix that was included in Debian for CVE-2012-1836 is incomplete,
    and does not solve the original remote code execution problem. See:

      https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=780880#5

  * a DoS can be triggered by invalid DNS packets. See:

      https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=780880#5
      https://github.com/inspircd/inspircd/commit/58c893e834ff20495d007709220881a3ff13f423



@maintainer(s): after the bump, in case we need to stabilize the package, please let us know if it is ready for the stabilization or not.
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2015-06-02 03:12:50 UTC
While designating this package to maintainer-needed is valid enough, doing so without any reasons provided?  Once abandoned to maintainer-needed it is likely to simply sit neglected. Is there any plan of action to actually bump this package (given the link @ $URL currently cites no CVE designation)?
Comment 2 Jeff (JD) Horelick (RETIRED) gentoo-dev 2015-06-15 21:00:57 UTC
I plan to bump this and take maintenance of this package as soon as my primary Gentoo system is back up and running. ETA is by the end of June 2015 at the latest.
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2015-06-22 07:30:31 UTC
(In reply to Jeff (JD) Horelick from comment #2)
> I plan to bump this and take maintenance of this package as soon as my
> primary Gentoo system is back up and running. ETA is by the end of June 2015
> at the latest.

All looks good.
Comment 4 Yury German Gentoo Infrastructure gentoo-dev 2015-07-16 11:46:14 UTC
2 CVE's Requested here - http://seclists.org/oss-sec/2015/q2/160
Comment 5 A. Wilcox (awilfox) 2015-07-27 10:41:34 UTC
Created attachment 407694 [details, diff]
InspIRCd 2.0.20 version of fix-path-builds

The net-irc/inspircd ebuild itself does not seem to require any changes.  Simply copying the 2.0.18 ebuild into my local overlay and renaming it 2.0.20, then adding this patch to files/, seems to have worked fine for various combinations of USE flags (though I did not test all permutations).
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2015-07-29 00:43:47 UTC
Unless, or until, a user like  Andrew Wilcox from the previous entry puts a hand up and eptresses interest in proxy maintaining this, I have no authority of involvement here. This would add authority of the proxy-maint herd as a participant. Also the end of June 2015 is about to be surpassed by the end of July.
Comment 7 Yury German Gentoo Infrastructure gentoo-dev 2015-09-02 13:30:44 UTC
(In reply to Jeff (JD) Horelick from comment #2)
> I plan to bump this and take maintenance of this package as soon as my
> primary Gentoo system is back up and running. ETA is by the end of June 2015
> at the latest.

Jeff, any interest in bumping this especially with Andrew providing some help?
Comment 8 A. Wilcox (awilfox) 2015-09-10 12:17:22 UTC
Created attachment 411502 [details]
2.0.20 ebuild

I would be happy to proxy-maintain this package.  Attached is the 2.0.20 ebuild (unchanged from 2.0.18).  Use along with the fix-path-builds patch attachment from earlier.
Comment 9 Pacho Ramos gentoo-dev 2015-09-10 21:10:05 UTC
Great, I will CC proxy-maintainers then ;)

Thanks
Comment 10 Ian Delaney (RETIRED) gentoo-dev 2015-09-13 08:06:04 UTC
(In reply to Andrew Wilcox from comment #8)
> Created attachment 411502 [details]
> 2.0.20 ebuild
> 
> I would be happy to proxy-maintain this package.  Attached is the 2.0.20
> ebuild (unchanged from 2.0.18).  Use along with the fix-path-builds patch
> attachment from earlier.

On runtesting, the ebuild fails to install unable to find the init file.
portage has under files
inspircd-2.0.17-init & inspircd-2.0.18-init

then in install phase it has newinitd "${FILESDIR}/${P}-init" "${PN}"
So ${P} no longer applies in an ebuild inspircd-2.0.20.ebuild.  This standard installation needs a file named generically so it is robust in version bumps. 

2 options; 
Either edit the entry in src_install to
newinitd "${FILESDIR}/${P/20/18}-init" "${PN}" (which lacks elegance 
or
rename or add a file under files to something like inspircd.initd and adjust the line above accordingly.  It will then apply robustly over version bumps.
(Copying the same file to a bumped name is imo a poor approach)
Comment 11 A. Wilcox (awilfox) 2015-09-15 14:59:25 UTC
I would definitely say the best course of action is to rename to inspircd-init as the files are identical.  Just did a quick test in my overlay and it worked fine.

Should the other ebuilds be revbumped and use this file as well to clean up files/, since it is identical?  Actually, I'm not sure the policy is for what to do with packages that have known security vulnerabilities.  Should the older versions be masked?  I can test 2.0.20 on at least i386 and ppc... probably mips and arm too if it'd help.  I'm already using the 2.0.20 ebuild on my amd64 laptop for testing different parts of IRCv3 that inspircd implements and it's been perfectly fine.
Comment 12 Ian Delaney (RETIRED) gentoo-dev 2015-09-17 15:24:08 UTC
I'll get onto this tomorrow. This is a security bug so old versions are planned to be purged. Let the sec team deal with that
Comment 13 Ian Delaney (RETIRED) gentoo-dev 2015-09-18 03:41:34 UTC

(In reply to Andrew Wilcox from comment #11)

> 
> Should the other ebuilds be revbumped and use this file as well to clean up
> files/, since it is identical?  

The file could be changed to inspircd-init (${PN}-init) but since it's already in place I so little point.  It can be removed post stabilising of -2.0.20.

> Actually, I'm not sure the policy is for
> what to do with packages that have known security vulnerabilities.  Should
> the older versions be masked?  I can test 2.0.20 on at least i386 and ppc...
> probably mips and arm too if it'd help.  I'm already using the 2.0.20 ebuild
> on my amd64 laptop for testing different parts of IRCv3 that inspircd
> implements and it's been perfectly fine.

We will deal this this by std procedure.


commit d7208425f4d0843462fbf24751c6807c1098e79e
Author: Ian Delaney <idella4@gentoo.org>
Date:   Fri Sep 18 11:36:22 2015 +0800

    net-irc/inspircd: bump to 2.0.20
    
    New maintainer added to metadata under proxy-maintainers herd,
    init file renamed to expand in any '{P}', new patch for fix-path-builds,
    ebuild and patch by new maintainer via bug #545034, rm 2.0.17
Comment 14 Ian Delaney (RETIRED) gentoo-dev 2015-09-22 13:17:02 UTC
inspircd-2.0.18.ebuild looks fine to be made stable
Please proceed
Comment 15 Agostino Sarubbo gentoo-dev 2015-09-23 10:02:35 UTC
amd64 stable
Comment 16 Agostino Sarubbo gentoo-dev 2015-09-23 10:03:48 UTC
x86 stable.

Maintainer(s), please cleanup.
Security, please add it to the existing request, or file a new one.
Comment 17 Ian Delaney (RETIRED) gentoo-dev 2015-09-24 02:08:17 UTC
(In reply to Ian Delaney from comment #14)
> inspircd-2.0.18.ebuild looks fine to be made stable
> Please proceed

I think I meant inspircd-2.0.20 which ago has made stable. Thx ago

Author: Ian Delaney <idella4@gentoo.org>
Date:   Thu Sep 24 10:05:19 2015 +0800

    net-irc/inspircd: cleanup wrt bug #545034
Comment 18 Yury German Gentoo Infrastructure gentoo-dev 2015-09-27 05:22:49 UTC
Arches and Maintainer(s), Thank you for your work.

New GLSA Request filed.
Comment 19 GLSAMaker/CVETool Bot gentoo-dev 2015-09-27 05:27:18 UTC
CVE-2015-6674 (http://nvd.nist.gov/nvd.cfm?cvename=CVE-2015-6674):
  ** RESERVED ** This candidate has been reserved by an organization or
  individual that will use it when announcing a new security problem. When the
  candidate has been publicized, the details for this candidate will be
  provided.
  
  ** TEMPORARY **
  package inspircd is vulnerable. problem of "i =- 12" where "i -= 12" was
  intended
Comment 20 GLSAMaker/CVETool Bot gentoo-dev 2015-12-30 21:28:41 UTC
This issue was resolved and addressed in
 GLSA 201512-13 at https://security.gentoo.org/glsa/201512-13
by GLSA coordinator Yury German (BlueKnight).