Attached is a candidate ebuild package for the webdot utility. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 63934 [details] webdot ebuild tarball ebuild tarball for webdot 2.2
(In reply to comment #1) > Created an attachment (id=63934) [edit] > webdot ebuild tarball No tarballs, please. Plaintext ebuild (and patches if needed) is all we need. http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=3#doc_chap2
Reopen once you've attached plaintext files. Thanks.
Created attachment 63986 [details] Webdot 2.2 ebuild
Created attachment 63987 [details] webdot ChangeLog Initial ChangeLog submission; should be updated by gentoo developer when package added to portage tree. Suggested category for this ebuild: media-gfx
Created attachment 63988 [details] webdot 2.2 digest
Sorry about that; I think the new attachments are in concordance with the documentation now, so I've re-opened this issue for consideration.
(In reply to comment #7) > Sorry about that; I think the new attachments are in concordance with > the documentation now, so I've re-opened this issue for consideration. Thanks. Just for future, digests and Changelog are not needed.
Please fix the following and reopen: * KEYWORDS are against policy. * ${S} needs quoting. * You should probably be using webapp-config for the locations.
* KEYWORDS are against policy. All KEYWORDS are tilde-prefixed, as per: http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml? part=2&chap=3#doc_chap2 It's unclear what policy you are referring to. * ${S} needs quoting. Huh? This statement needs quoting?!: cd ${S} Or this one?!: cd ${S}/html/webdot These (and similar) are the only uses of ${S} in the ebuild. I'm afraid I don't understand your requirement.
(In reply to comment #10) > All KEYWORDS are tilde-prefixed, as per: > > http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml? > part=2&chap=3#doc_chap2 Ok, so I assume that you personally tested the ebuild on alpha amd64 arm hppa ia64 m68k mips ppc ppc64 ppc-macos ppc-od s390 sh sparc x86 x86-fbsd x86-obsd x86-od If you actually haven't, then remove all the keywords where this ebuild is untested.
Created attachment 66318 [details] Webdot 2.2 ebuild trimmed keywords
(In reply to comment #11) > Ok, so I assume that you personally tested the ebuild on > > alpha amd64 arm hppa ia64 m68k mips ppc ppc64 ppc-macos ppc-od s390 sh sparc x86 > x86-fbsd x86-obsd x86-od No, I didn't specifically run it myself on all of those architectures. However, it's a TCL script. It's architecture independent. > If you actually haven't, then remove all the keywords where this ebuild is untested. Done.
Yeah, ${S} could potentially at some point in the distant future, so we're trying (slowly) to get it quoted to avoid problems. I can guarantee that your package won't work on at least some of your original arch list. Keyword policy says ~ keywords only for things on which it has been tested, not on things on which you think it might work. This still needs to be switched to use webapp-config to determine webserver paths. Thanks
(In reply to comment #14) > Yeah, ${S} could potentially at some point in the distant future, so we're > trying (slowly) to get it quoted to avoid problems. OK, so if I understand correctly, you are requesting the shell code in the ebuild to change to: cd "${S}" I'll make this change in the next update (or let me know if I've missed the mark here). > This still needs to be switched to use webapp-config to determine webserver paths. OK. I was unaware of webapp-config (and lots of other stuff, obviously :-). I knew the internal assumptions were a hack, but couldn't find any existing ebuilds that pointed me in the right direction. I'll work on getting it converted over before I re-open this one. > Thanks Thanks for the additional clarification. BTW, it might help if there was some documentation that gave more specifics about creating ebuilds. The documentation that exists (that I've seen) is good but pretty general. Adding links to sub-documents for specific categories of ebuilds (e.g. webtools, python extensions, tetex packages, etc.) would be helpful. Also, some notes about the intended direction of ebuilds, like adding the quoting to ${S} and the like. I assume most ebuilds are based on existing ebuilds; the latter information could save some of the back-and-forth that I've caused on this one, and which I suspect you're dealing with elsewhere as well.
