Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 94731 - kdeutils fails compilation if pbbuttonsd >= 0.6.8 is installed
Summary: kdeutils fails compilation if pbbuttonsd >= 0.6.8 is installed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: PPC Other
: High normal (vote)
Assignee: Gentoo KDE team
URL: https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard:
Keywords:
: 97802 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-06-01 06:00 UTC by Joe Jezak (RETIRED)
Modified: 2005-08-04 07:58 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
This patch applies cleanly to 3.4.0 and 3.4.1 (kdeutils-3.4.0-pbbuttonsd-fix.patch,326 bytes, patch)
2005-06-01 06:01 UTC, Joe Jezak (RETIRED)
Details | Diff
Updated patch (pbbutonsd.patch,398 bytes, patch)
2005-07-03 09:56 UTC, Joe Jezak (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Jezak (RETIRED) gentoo-dev 2005-06-01 06:00:07 UTC
As I explained in the kde bug above, pbbuttonsd changed its function for starting the ipc.  With versions of pbbuttonsd >= 0.6.8, kdeutils fails when compiling powerbook2.  The attached patch fixes the problem, but makes kdeutils dependent on pbbuttonsd >= 0.6.8.

If you need more details, please let me know.
Comment 1 Joe Jezak (RETIRED) gentoo-dev 2005-06-01 06:01:53 UTC
Created attachment 60357 [details, diff]
This patch applies cleanly to 3.4.0 and 3.4.1
Comment 2 Carsten Lohrke (RETIRED) gentoo-dev 2005-06-01 14:21:24 UTC
Moreover I wonder why kdeutils is marked ppc, but the dependency is missing at
all. The kde herd is small and x86/amd64 only, we rely on you spotting such
minor missing dependencies.

When will pbbuttonsd 0.6.8 go stable?
Comment 3 Carsten Lohrke (RETIRED) gentoo-dev 2005-06-01 14:24:11 UTC
s/marked ppc/keyworded ppc
Comment 4 Joe Jezak (RETIRED) gentoo-dev 2005-06-01 21:15:51 UTC
It's not a hard dependency.  If pbbuttonsd isn't present, it doesn't build the
powerbook libraries.  At least that's what it looks like from the config files
and this would explain the lack of bug reports on it.  So, it's perfectly
understandable that ppc missed it as a dependency as well.  Only portable Apple
laptops use this package, and kdeutils builds fine without pbbuttonsd, just
without powerbook support.  Non-laptop ppc machines should not depend on
pbbuttonsd, so we probably need a use flag for it.

I don't think that pbbuttonsd-0.6.8 will go stable soon, as we're working on a
crash bug with versions 0.6.8 - 0.6.10 and I'm not sure when this will be
resolved.  I created this bug as an FYI, this is a problem, here is the fix.
Comment 5 Carsten Lohrke (RETIRED) gentoo-dev 2005-06-02 07:20:52 UTC
> It's not a hard dependency.

So it needs to become one, optionalised by a use flag. Untracked depedencies are
the worst next to boken autodetection code in build scripts, overriding
configure flags. Joe, we really need to track _all_ dependencies of _all_
ebuilds in a determinist way, otherwise we'll never see a Portage version with
proper reverse dependency tracking.
Comment 6 Joe Jezak (RETIRED) gentoo-dev 2005-06-02 08:55:47 UTC
Look, I'm not arguing with you, no need to get all worked up.  I don't use KDE.
 A user pointed out the problem and we're fixing it.  I suggested that we use a
USE flag in my previous post, I'm *agreeing* with you.
Comment 7 Carsten Lohrke (RETIRED) gentoo-dev 2005-06-02 17:02:44 UTC
O.k., o.k. ;) Is a "powerbook" use flag fine then? Or does it work with iBooks,
too and e.g. "apple-laptop" would be more appropriate?


for reference: https://bugs.kde.org/show_bug.cgi?id=104517
Comment 8 Joe Jezak (RETIRED) gentoo-dev 2005-06-02 19:39:33 UTC
Well, I'd probably use "pbbuttonsd" as there is still support for pmu (Apple's
version of apm) without pbbuttonsd.  pbbuttonsd support allows the use of the
special buttons, such as volume and sound.  The powerbook2 module provides
visual feedback to the user when these buttons are pressed in KDE.
Comment 9 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-06-03 00:47:21 UTC
pbbuttonsd should be good, as ibooks users usually use that, too. 
Comment 10 Carsten Lohrke (RETIRED) gentoo-dev 2005-07-03 08:56:07 UTC
*** Bug 97802 has been marked as a duplicate of this bug. ***
Comment 11 Joe Jezak (RETIRED) gentoo-dev 2005-07-03 09:51:44 UTC
FYI the upstream patch has support for all versions of pbbuttonsd.  If we
include this patch instead and add the pbbuttonsd useflag we can close this bug now.
Comment 12 Joe Jezak (RETIRED) gentoo-dev 2005-07-03 09:56:52 UTC
Created attachment 62553 [details, diff]
Updated patch
Comment 13 Carsten Lohrke (RETIRED) gentoo-dev 2005-07-03 10:37:56 UTC
We can. But I don't like to name the use flag "pbbuttonsd". Imho use flags
should be as abstract as possible, so they can be reused. We have already too
much crappy named and even redundant use flags, making Portage far more complex
than necessary. 

Fear the bloated Gentoo! It won't be the most speedy penguin anymore. :)
Comment 14 Joe Jezak (RETIRED) gentoo-dev 2005-07-03 11:05:05 UTC
Well, what do you suggest then?  I don't want to make it conditional on ppc
since non laptop users don't need pbbuttonsd at all.  We can't use
powerbook/ibook because both use pbbuttonsd.  If there was an existing laptop
use flag, I would suggest use ppc && use laptop but since there isn't, it would
be just as wasteful to add one.
Comment 15 Joe Jezak (RETIRED) gentoo-dev 2005-07-26 07:50:48 UTC
Carsten, would you like me to just apply the patch myself?
Comment 16 Gregorio Guidi (RETIRED) gentoo-dev 2005-07-26 09:18:40 UTC
At this point we can just wait a couple of days for kde 3.4.2, which includes 
the patch for pb_monitor.cpp and will be also patched to have a 
--with-powerbook/--without-powerbook switch. Then you can add there the 
optional dependency on pbbuttonsd with a USE flag to be decided. 
 
Comment 17 Gregorio Guidi (RETIRED) gentoo-dev 2005-07-30 02:56:40 UTC
kde 3.4.2 is in portage now, feel free to add an USE flag and a dependency on   
pbbuttonsd to kde-base/kdeutils and kde-base/kmilo. 
 
Comment 18 Joe Jezak (RETIRED) gentoo-dev 2005-08-04 07:58:20 UTC
Fixed in CVS, thanks!