> || ( > =dev-libs/leveldb-1.20 > =dev-libs/leveldb-1.18-r2 > =dev-libs/leveldb-1.18 > =dev-libs/leveldb-1.17 > =dev-libs/leveldb-1.15.0-r1 > ) Except for dev-libs/leveldb-1.20, all versions are already gone from ::gentoo. 1.23 is missing from this list. Why is that?
The developers of Bitcoin Core insist that all libraries in the consensus-critical path form part of the network's consensus rules, and thus even their bugs (known and unknown) are incorporated by reference into those consensus rules. As such, versions of consensus-critical libraries that are not known to have exactly the same bugs are deemed incompatible. I personally think it's an idiotic argument, but that's what it is. I would happy to drop the "system-leveldb" USE flag from net-p2p/bitcoin-core so virtual/bitcoin-leveldb could be tree-cleaned. That flag is already off by default to prevent pinning dev-libs/leveldb at outdated versions. Dropping it entirely would reduce the patching that has to be done to Bitcoin Core's build system.
> Except for dev-libs/leveldb-1.20, all versions are already gone from ::gentoo. 1.23 is missing from this list. > > Why is that? Upstream LevelDB does not guarantee consensus-compatibility, and to date nobody has reviewed 1.23 for it. IIRC, 1.22 should be fine, but has already been pruned from the tree. (If you want to restore it, someone should verify that - there's ~5000 lines difference)
dev-libs/leveldb-1.23 was added to ::gentoo on Fri Aug 13 16:17:07 2021. Ridiculous is the nicest thing I can say about that situation.
When Gentoo adds ebuilds has no relevance whatsoever to the degree of code review performed or guarantees made. The entire purpose of virtual/bitcoin-leveldb is to ensure a version of leveldb with the expected guarantees is installed.
It has relevance to if it can possibly be supported in Gentoo.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83e10bce93ec9d11ae97ee5466e8592a5ca350c6 commit 83e10bce93ec9d11ae97ee5466e8592a5ca350c6 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2024-12-28 16:32:29 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2024-12-28 16:59:22 +0000 profiles: Mask virtual/bitcoin-leveldb for removal Bug: https://bugs.gentoo.org/945359 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> profiles/package.mask | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=60d73d18ff8d8fcc8701ab5df62401e9c6ca98a0 commit 60d73d18ff8d8fcc8701ab5df62401e9c6ca98a0 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2024-12-28 16:36:35 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2024-12-28 16:59:22 +0000 profiles: base: Mask net-p2p/bitcoin-core[system-leveldb] In preparation of virtual/bitcoin-leveldb last-rites. Bug: https://bugs.gentoo.org/945359 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> profiles/base/package.use.mask | 4 ++++ 1 file changed, 4 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=156f5b2bb4c85ecdcf598200e9035380c00f9479 commit 156f5b2bb4c85ecdcf598200e9035380c00f9479 Author: Sam James <sam@gentoo.org> AuthorDate: 2025-01-09 10:05:07 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2025-01-09 10:06:38 +0000 profiles: refine transitional bitcoin mask last-rites Clarify that net-p2p/bitcoin-core is the new package to use. It's the same as the previous stuff but merged into one to be more maintainable. Bug: https://bugs.gentoo.org/945359 Signed-off-by: Sam James <sam@gentoo.org> profiles/package.mask | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
