Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 943 - fluxbox-0.1.7-r1.ebuild: fix/enable gnome support
Summary: fluxbox-0.1.7-r1.ebuild: fix/enable gnome support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Karl Trygve Kalleberg (RETIRED)
URL: http://www.numlock.ch
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-03-03 11:38 UTC by Daniel Mettler
Modified: 2003-02-04 19:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fluxbox-0.1.7-r1.ebuild (fluxbox-0.1.7-r1.ebuild,1.31 KB, application/octet-stream)
2002-03-03 11:40 UTC, Daniel Mettler
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Mettler 2002-03-03 11:38:44 UTC
hia,

here's a tiny patch to fix/enable the new gnome support feature (also required
for sticky xmms) in fluxbox-0.1.7:

just make sure "gnome" is added to your use variable setting and (r)emerge fluxbox

the patch:

--- fluxbox-0.1.7.ebuild        Sat Mar  2 09:29:56 2002
+++ fluxbox-0.1.7-r1.ebuild     Sun Mar  3 17:14:09 2002
@@ -11,6 +11,7 @@
 DEPEND="virtual/x11
        virtual/glibc
        kde? ( >=kde-base/kdebase-2.1 )
+       gnome? ( >=gnome-base/gnome-1.4-r3 )
        nls? ( >=sys-devel/gettext-0.10.38 ) "

 RDEPEND="$DEPEND"
@@ -21,7 +22,9 @@
                || myconf="$myconf --disable-nls"
        use kde && myconf="$myconf --enable-kde" \
                && export KDEDIR=/usr/kde/2 \
-               || myconf="$myconf --disable-kde"
+               || myconf="$myconf --disable-kde" \
+       use gnome && myconf="$myconf --enable-gnome" \
+               || myconf="$myconf --disable-gnome"

        ./configure \
                --host=${CHOST} \

the digest-file:

root@hal files # cat digest-fluxbox-0.1.7-r1 
MD5 bb2c250128bbd1f33cbb5a1ca9e59615 fluxbox-0.1.7.tar.gz 430253

notes:
* fluxbox actually does not seem to _really require_ any gnome-libs, kde-libs,
gettext neither at build- nor run-time, even if gnome-, kde-, nls-support is
enabled. thus i'd suggest to remove these dependencies as they "force" the
people to emerge gnome etc. at the same time as fluxbox even if it would be
sufficient to emerge these apps when they really need them (e.g. later). btw. i
am still not sure about the exact target of portage's r/depend system (have read
the docs though). are these "hard" dependencies (the app does not compile/run
without these dependencies resolved) or also "soft" dependencies (more of a
convenience enhancement for the user so he does not need to emerge "suggested"
companion apps manually. thus the app runs without them, but the user can't
leverage the feature without these)?
* i set the deps to >=gnome-base/gnome-1.4-r3 (the gnome-version i tested it
with, as suggested in skel.ebuild). but i do not like the idea very much of
perhaps "forcing" the users to remerge gnome although it is not required at all.
actually i'd generally prefer ( gnome-base/gnome ) alike dependencies if a
dependency is not version related... (or am i missing the reason for the policy
suggested in skel.ebuild?)

conclusion: i'd remove these dependencies (disclaimer: haven't tested it yet
though as i have gnome/kde already installed -> somebody else perhaps?):

patch2:

--- fluxbox-0.1.7-r1.ebuild     Sun Mar  3 17:14:09 2002
+++ fluxbox-0.1.7-r2.ebuild     Sun Mar  3 18:17:59 2002
@@ -9,10 +9,7 @@
 HOMEPAGE="http://fluxbox.sf.net"

 DEPEND="virtual/x11
-       virtual/glibc
-       kde? ( >=kde-base/kdebase-2.1 )
-       gnome? ( >=gnome-base/gnome-1.4-r3 )
-       nls? ( >=sys-devel/gettext-0.10.38 ) "
+       virtual/glibc"

 RDEPEND="$DEPEND"

the digest-file2:

root@hal files # cat digest-fluxbox-0.1.7-r2 
MD5 bb2c250128bbd1f33cbb5a1ca9e59615 fluxbox-0.1.7.tar.gz 430253

regards

dani

ps. sorry for this over-sized discription...
Comment 1 Daniel Mettler 2002-03-03 11:40:03 UTC
Created attachment 282 [details]
fluxbox-0.1.7-r1.ebuild
Comment 2 Daniel Mettler 2002-03-06 19:59:13 UTC
hi karl, i have just noticed that somehow my bug report got lost as it was
assigned to drobbins by default (although you are the maintainer of the fluxbox
ebuild). in your fluxbox-0.1.7-r2.ebuild you now enabled gnome-support. but the
dependencies are still wrong (see my bug report). it should be safe to ignore
the current build-time dependencies of fluxbox regarding gnome, kde and nls
(they are not required at build-time and even not at run time for a proper
function of fluxbox). regards, dan
Comment 3 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2002-03-08 18:06:48 UTC
Added proper GNOME dependency. Even if Fluxbox at the current stage doesn't
require any parts of GNOME to be present for --enable-gnome, we depend on the
GNOME core regardless.

Makes it easier to maintain, without placing an extreme burden on the user.
Advanced users who understand the intricacies of fluxbux should be able to
modify their ebuild script anyway :)