Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 940253 - dev-python/rpyc: reinvents every Python eclass variable/function possible
Summary: dev-python/rpyc: reinvents every Python eclass variable/function possible
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Andrey Grozin
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 803152
  Show dependency tree
 
Reported: 2024-09-26 04:44 UTC by Michał Górny
Modified: 2025-04-29 14:41 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-09-26 04:44:58 UTC
The ebuild suffers from serious NIH:

> do PYTHONPATH="${WORKDIR}"/${P}-${EPYTHON/./_}/install/usr/lib/${EPYTHON}/site-packages ${EPYTHON} ${x} || die "${x} failed"

This is reinventing ${BUILD_DIR}, $(python_get_sitedir) (and both of them poorly), and on top of that, setting PYTHONPATH here should be completely unnecessary here since the eclass does that.
Comment 1 Andrey Grozin gentoo-dev 2025-04-29 14:41:58 UTC
(In reply to Michał Górny from comment #0)
> setting PYTHONPATH here should be completely
> unnecessary here since the eclass does that.
Without setting PYTHONPATH I get

Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/rpyc-6.0.2/work/rpyc-6.0.2/tests/test_affinity.py", line 4, in <module>
    from tests import support
ModuleNotFoundError: No module named 'tests'