Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 939842 - media-gfx/krita-5.2.3[test] fails to build: kis_composition_benchmark_SSSE3.cpp:643:92: error: ‘struct xsimd::detail::supported_arch’ has no member named ‘best’
Summary: media-gfx/krita-5.2.3[test] fails to build: kis_composition_benchmark_SSSE3.c...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2024-09-19 07:56 UTC by ditto
Modified: 2025-01-25 13:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,9.74 KB, text/plain)
2024-09-19 07:57 UTC, ditto
Details
build.log (build.log.xz,212.48 KB, application/x-xz)
2024-09-19 08:02 UTC, ditto
Details
media-gfx-krita-5.2.6-build.log (build.log.xz,188.90 KB, application/x-xz)
2024-10-11 16:51 UTC, ditto
Details
krita-xsimd-disable-best-member.patch (krita-xsimd-disable-best-member.patch,1.13 KB, patch)
2025-01-13 07:26 UTC, ditto
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ditto 2024-09-19 07:56:33 UTC
FAILED: benchmarks/CMakeFiles/kis_composition_benchmark_SSSE3.dir/kis_composition_benchmark_SSSE3.cpp.o
/usr/bin/x86_64-pc-linux-gnu-g++ -DFILES_DATA_DIR=\"/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/benchmarks/data/\" -DFILES_DEFAULT_DATA_DIR=\"/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/sdk/tests/data/\" -DFILES_OUTPUT_DIR=\"/var/tmp/portage/media-g
fx/krita-5.2.3/work/krita-5.2.3_build/benchmarks\" -DHAVE_X11 -DKCOREADDONS_LIB -DKGUIADDONS_LIB -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DEPRECATED_WARNINGS -DQT_DISABLE_DEPRECATED_BEFORE=0x50900 -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FRO
M_STRING -DQT_PRINTSUPPORT_LIB -DQT_SQL_LIB -DQT_STRICT_ITERATORS -DQT_SVG_LIB -DQT_TESTCASE_BUILDDIR=\"/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build\" -DQT_TESTLIB_LIB -DQT_USE_FAST_CONCATENATION -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER -DQT_WID
GETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -DSYSTEM_RESOURCES_DATA_DIR=\"/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/krita/data/\" -DTRANSLATION_DOMAIN=\"krita\" -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DXSIMD_IMPL=SSSE3 -I/var/tmp/portage/media-gfx/krita-5.2.3/work/
krita-5.2.3_build/benchmarks -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/benchmarks -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/benchmarks/kis_composition_benchmark_SSSE3_autogen/include -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-
5.2.3_build -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3 -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/image/brushengine -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/image/filter -I/var/tmp/portage/media-gfx/krita-5.2.3/work/
krita-5.2.3/libs/image/generator -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/image/layerstyles -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/image/processing -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/image -I/v
ar/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/image -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/version -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/version -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_bu
ild/libs/widgets -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/widgets -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/global -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/global -I/var/tmp/portage/media-gfx/krita-5.2.
3/work/krita-5.2.3/libs/flake/commands -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/flake/tools -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/flake/svg -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/flake/text -I/var/tmp/p
ortage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/flake -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/flake -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/pigment/resources -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/li
bs/pigment/compositeops -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/pigment -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/pigment -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/koplugin -I/var/tmp/portage/medi
a-gfx/krita-5.2.3/work/krita-5.2.3/libs/koplugin -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/store -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/store -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/resources -
I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/resources -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/command -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/command -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5
.2.3/libs/widgetutils/config -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/widgetutils/xmlgui -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/widgetutils -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/widgetutils -I/var
/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/multiarch -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/multiarch -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/resourcewidgets -I/var/tmp/portage/media-gfx/krita-5.2.3/w
ork/krita-5.2.3/libs/resourcewidgets -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/psdutils -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/psdutils -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/libs/metadata -I/var/t
mp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/libs/metadata -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/sdk/tests -I/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3/sdk/tests -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem
 /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtConcurrent -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtXml -isystem /usr/include/KF5/KI18n -isystem /usr/include/KF5 -isystem /usr/include/qt5/QtSql -isystem /
usr/include/KF5/KItemViews -isystem /usr/include/KF5/KConfig -isystem /usr/include/KF5/KConfigGui -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/OpenEXR -isystem /usr/include/Imath -isystem /usr/include/KF5/KWidgetsAddons -isystem /usr/include/qt5/QtSvg -isyst
em /usr/include/KF5/KCoreAddons -isystem /usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem /usr/include/qt5/QtPrintSupport -isystem /usr/include/KF5/KGuiAddons -isystem /usr/include/KF5/KCompletion -isystem /usr/include/qt5/QtX11Extras -isystem /usr/include/ei
gen3 -isystem /usr/include/qt5/QtTest  -DQT_NO_DEBUG -march=native -O2 -pipe -fvect-cost-model=cheap -fno-operator-names -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=re
turn-type -Werror=init-self -Wvla -Wdate-time -Wsuggest-override -Wlogical-op -fdiagnostics-color=always  -fext-numeric-literals -fexceptions -std=gnu++17 -fvisibility=hidden -fvisibility-inlines-hidden -Wno-suggest-override -Wextra -Wno-class-memaccess -fPIC  -Wabi -fabi-
version=0 -fabi-compat-version=0 -ffp-contract=fast -fPIC -mssse3 -MD -MT benchmarks/CMakeFiles/kis_composition_benchmark_SSSE3.dir/kis_composition_benchmark_SSSE3.cpp.o -MF benchmarks/CMakeFiles/kis_composition_benchmark_SSSE3.dir/kis_composition_benchmark_SSSE3.cpp.o.d -
o benchmarks/CMakeFiles/kis_composition_benchmark_SSSE3.dir/kis_composition_benchmark_SSSE3.cpp.o -c /var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/benchmarks/kis_composition_benchmark_SSSE3.cpp
/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/benchmarks/kis_composition_benchmark_SSSE3.cpp: In member function ‘void KisCompositionBenchmark::detectBuildArchitecture()’:
/var/tmp/portage/media-gfx/krita-5.2.3/work/krita-5.2.3_build/benchmarks/kis_composition_benchmark_SSSE3.cpp:643:92: error: ‘struct xsimd::detail::supported_arch’ has no member named ‘best’
  643 |     qDebug().nospace() << "running on " << hex << "0x" << xsimd::available_architectures().best;
      |                                                                                            ^~~~
ninja: build stopped: subcommand failed.

Reproducible: Always
Comment 1 ditto 2024-09-19 07:57:55 UTC
Created attachment 903328 [details]
emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-09-19 08:00:24 UTC
https://invent.kde.org/graphics/krita/-/blob/master/benchmarks/kis_composition_benchmark.cpp#L643

but clearly the configuration isn't tested.

Please also always include the full build.log.
Comment 3 ditto 2024-09-19 08:02:08 UTC
Created attachment 903329 [details]
build.log
Comment 4 Andreas Sturmlechner gentoo-dev 2024-09-19 08:12:17 UTC
How did you end up with that version number in $summary?
Comment 5 ditto 2024-09-19 08:22:29 UTC
Oh, my bad, was copying bug report's skeleton from an another bug.
Comment 6 Andreas Sturmlechner gentoo-dev 2024-10-02 18:15:07 UTC
Please test with 5.2.6.
Comment 7 ditto 2024-10-11 16:51:56 UTC
Created attachment 905183 [details]
media-gfx-krita-5.2.6-build.log

Hello. It fails in a similar fashion.
Comment 9 ditto 2025-01-13 07:26:56 UTC
Created attachment 916418 [details, diff]
krita-xsimd-disable-best-member.patch

Thanks to Sam (again!), the patch from upstream's commit helped to solve this. Since that didn't work as is, I've attached working patch.
Comment 10 Andreas Sturmlechner gentoo-dev 2025-01-25 12:10:27 UTC
I guess the other question is why we build "benchmarks" subdir at all with FEATURES=test. Upstream made them conditional on BUILD_TESTING, which does not necessarily mean tests themselves need benchmarks dir.
Comment 11 Larry the Git Cow gentoo-dev 2025-01-25 13:27:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9be76b1a45de787bf8e56c5329c83f2e9dda2de3

commit 9be76b1a45de787bf8e56c5329c83f2e9dda2de3
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2025-01-25 12:48:38 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-01-25 13:22:40 +0000

    media-gfx/krita: Uncoditionally disable build of benchmarks dir
    
    Conditional upstream on BUILD_TESTING, but tests are restricted anyway,
    while at least still building fine after this.
    
    Closes: https://bugs.gentoo.org/939842
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-gfx/krita/krita-5.2.6.ebuild | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)