Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 939277 - dev-python/pipenv: blocks on ~dev-python/importlib-metadata-8.4.0, ~dev-python/plette-0.4.4, ~dev-python/pipdeptree-2.18.1
Summary: dev-python/pipenv: blocks on ~dev-python/importlib-metadata-8.4.0, ~dev-pytho...
Status: IN_PROGRESS
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: OzTiram
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-09-07 10:26 UTC by Michał Górny
Modified: 2024-11-15 06:06 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-09-07 10:26:02 UTC
NonsolvableDepsInStable: version 2024.0.1: nonsolvable depset(rdepend) keyword(amd64) stable profile (default/linux/amd64/23.0) (37 total): solutions: [ ~dev-python/importlib-metadata-7.1.0[python_targets_python3_10(-),python_targets_python3_11(-),python_targets_python3_12(-)] ]
Comment 1 OzTiram 2024-09-13 21:46:58 UTC
We released an upstream version. importlib-metadata is updated. I will publish a new ebuild in the coming days.
Comment 2 Larry the Git Cow gentoo-dev 2024-09-27 05:56:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7494f7eea2c9a8694d841c36646189b7275cf20e

commit 7494f7eea2c9a8694d841c36646189b7275cf20e
Author:     Oz Tiram <oz.tiram@gmail.com>
AuthorDate: 2024-09-14 21:27:49 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-09-27 05:55:56 +0000

    dev-python/pipenv: bump importlib-metadata-8.4.0
    
    Closes: https://bugs.gentoo.org/939277
    Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/38607
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 dev-python/pipenv/pipenv-2024.0.1-r1.ebuild | 124 ++++++++++++++++++++++++++++
 1 file changed, 124 insertions(+)
Comment 3 OzTiram 2024-09-27 06:57:27 UTC
Why not merged the new ebuild?
Comment 4 Eli Schwartz gentoo-dev 2024-09-27 19:59:50 UTC
What do you mean?


$ git --no-pager log -2 -- dev-python/pipenv/
commit 7494f7eea2c9a8694d841c36646189b7275cf20e
Author:     Oz Tiram <oz.tiram@gmail.com>
AuthorDate: Sat Sep 14 17:27:49 2024
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: Fri Sep 27 01:55:56 2024

    dev-python/pipenv: bump importlib-metadata-8.4.0
    
    Closes: https://bugs.gentoo.org/939277
    Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/38607
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

commit 0075c28ae205444a16149db7c15d187df4079cf5
Author:     Oz Tiram <oz.tiram@gmail.com>
AuthorDate: Sat Sep 14 17:24:12 2024
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: Fri Sep 27 01:55:56 2024

    dev-python/pipenv: add 2024.0.2
    
    Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>



The automated infra-gitbot notification hook only posts about commits that include "Bug:" or "Closes:" taglines, not about all commits merged at the same time.
Comment 5 OzTiram 2024-09-28 04:56:13 UTC
Sorry, I was quick to response.
The newer ebuild was merged as I was posting my message.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-09-28 11:23:25 UTC
I would hardly call it solved.  The only difference is that now it blocks on two old versions.
Comment 7 Eli Schwartz gentoo-dev 2024-09-29 01:46:12 UTC
Ah right... can we just rapid-stable 2024.0.1-r1 then and drop the old version, as it should be fully compatible?
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-10-12 07:22:50 UTC
Seriously, I still don't get how badly broken this package has to be to require exact version of importlib-metadata.
Comment 9 OzTiram 2024-10-12 09:23:56 UTC
pipenv requires the same version as vendored in the upstream version.
Since the ebuild has unvendored the  importlib-metadata package.

I am not entirely sure, but it might be that only pinning the minor level would be ok. That is:

8.5.0 should work, but not 9.x.y

As for the dependency on plette-0.4.4 that is simply wrong. Current versions of pipenv use plette 2.1.0 (that's on me, not updating it).


As for pipdeptree, it's the same story as with importlib-metadata. I will bump pipdeptree upstream first, and then I can tell if we can lift the fix in gentoo.
Comment 10 OzTiram 2024-10-12 20:29:50 UTC
Regarding pipdeptree: bumping the package in gentoo should work.

I already opened a PR for bumping plette, should I add another commit on the same PR to bump pipdeptree?
Comment 11 Eli Schwartz gentoo-dev 2024-10-13 04:20:28 UTC
Sure, no reason not to batch the changes.
Comment 12 OzTiram 2024-10-13 17:50:14 UTC
The latest pipenv-2024.0.2-r1 has bumped plette and pipdeptree.
Comment 13 Larry the Git Cow gentoo-dev 2024-11-15 06:06:37 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f54792c34e4310032131818ce72bd0d509057b4

commit 9f54792c34e4310032131818ce72bd0d509057b4
Author:     Oz Tiram <oz.tiram@gmail.com>
AuthorDate: 2024-10-13 17:59:34 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-11-15 06:05:44 +0000

    dev-python/pipenv: unpin importlib-metadata dep
    
    Allow everything smaller than version 9.
    
    Bug: https://bugs.gentoo.org/939277
    Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/38961
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 dev-python/pipenv/pipenv-2024.0.2-r1.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0fa76e4edef89d0b9162804a93aadf44d79f997e

commit 0fa76e4edef89d0b9162804a93aadf44d79f997e
Author:     Oz Tiram <oz.tiram@gmail.com>
AuthorDate: 2024-10-13 17:45:02 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-11-15 06:05:44 +0000

    dev-python/pipenv: bump plette and pipdeptree
    
    Plette dependency in gentoo was outdated in gentoo and
    didn't match upstream.
    Also remove markupsafe and requests from dependencies as
    they are not longer direct dependencies of pipenv.
    
    Bug: https://bugs.gentoo.org/939277
    Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 dev-python/pipenv/pipenv-2024.0.2-r1.ebuild | 122 ++++++++++++++++++++++++++++
 1 file changed, 122 insertions(+)