Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 937108 - games-fps/chocolate-doom-3.1.0 version bump
Summary: games-fps/chocolate-doom-3.1.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-08-01 23:15 UTC by William Breathitt Gray
Modified: 2024-12-01 12:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description William Breathitt Gray 2024-08-01 23:15:11 UTC
Chocolate Doom version 3.1.0 was released on August 1, 2024: https://github.com/chocolate-doom/chocolate-doom/releases/tag/chocolate-doom-3.1.0

The patches we have been applying in Gentoo for games-fps/chocolate-doom were merged upstream and incorporated in this release of Chocolate Doom.
Comment 1 Abdul 2024-10-21 23:57:01 UTC
I would like to fix this bug but i don't know how I'm supposed to contribute to ::gentoo. Who should I contact?
Comment 2 William Breathitt Gray 2024-10-22 00:10:29 UTC
(In reply to Abdul from comment #1)
> I would like to fix this bug but i don't know how I'm supposed to contribute
> to ::gentoo. Who should I contact?

I think the easiest way to contribute would be to fork the gentoo/gentoo tree on GitHub and open a pull request: https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#How_to_submit_package_updates

That Proxy Maintainers wiki page also provides information on how to become a proxy maintainer in case you wish to continue contributing to ::gentoo.
Comment 3 Abdul 2024-10-22 00:16:09 UTC
(In reply to William Breathitt Gray from comment #2)
> (In reply to Abdul from comment #1)
> > I would like to fix this bug but i don't know how I'm supposed to contribute
> > to ::gentoo. Who should I contact?
> 
> I think the easiest way to contribute would be to fork the gentoo/gentoo
> tree on GitHub and open a pull request:
> https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/
> User_Guide#How_to_submit_package_updates
> 
> That Proxy Maintainers wiki page also provides information on how to become
> a proxy maintainer in case you wish to continue contributing to ::gentoo.

Thanks William! 
I started out on ::guru because I didn't know how to contribute to ::gentoo lol.
Comment 4 Abdul 2024-10-22 01:27:57 UTC
William, should I remove ALL the patches?
Comment 5 Abdul 2024-10-22 01:28:32 UTC
Because there's a lot of patches here and it's hard to tell what's actually needed vs. what is just a backported fix.
Comment 6 Abdul 2024-10-22 01:44:41 UTC
Well, the game does compile just fine with all the patches removed. And as far as I know, no new bugs have been introduced.
Comment 7 Abdul 2024-10-25 19:23:10 UTC
I fixed the PR on github, please merge it.
Comment 8 Larry the Git Cow gentoo-dev 2024-12-01 12:04:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df45f3841d026c6155a4e31815fa0678697c9e3c

commit df45f3841d026c6155a4e31815fa0678697c9e3c
Author:     Abdelrahman Sarhan <abdulrahmanayman1@gmail.com>
AuthorDate: 2024-10-24 22:42:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-01 12:00:57 +0000

    games-fps/chocolate-doom: add 3.1.0
    
    Closes: https://bugs.gentoo.org/937108
    Signed-off-by: Abdelrahman Sarhan <abdulrahmanayman1@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 games-fps/chocolate-doom/Manifest                  |  1 +
 .../chocolate-doom/chocolate-doom-3.1.0.ebuild     | 71 ++++++++++++++++++++++
 2 files changed, 72 insertions(+)