Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934768 - app-crypt/sbctl-0.14: bashism in kernel install script
Summary: app-crypt/sbctl-0.14: bashism in kernel install script
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: John Helmert III
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: nonbash
  Show dependency tree
 
Reported: 2024-06-23 12:04 UTC by foearb
Modified: 2024-06-27 18:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description foearb 2024-06-23 12:04:47 UTC
The file 91-sbctl.install uses `if [[ ]]` that doesn't work with dash.
I'd suggest back-porting the upstream fix from https://github.com/Foxboron/sbctl/commit/1167500b9da76febe85342e09b1bf9eeaf367ca6
Comment 1 Larry the Git Cow gentoo-dev 2024-06-27 18:34:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=becfea3c2a348982323838e525525d57501b0c07

commit becfea3c2a348982323838e525525d57501b0c07
Author:     Steffen Winter <steffen.winter@proton.me>
AuthorDate: 2024-06-23 14:44:48 +0000
Commit:     John Helmert III <ajak@gentoo.org>
CommitDate: 2024-06-27 18:34:21 +0000

    app-crypt/sbctl: backport bashism fix in kernel install hook
    
    Closes: https://bugs.gentoo.org/934768
    Signed-off-by: Steffen Winter <steffen.winter@proton.me>
    Closes: https://github.com/gentoo/gentoo/pull/37253
    Signed-off-by: John Helmert III <ajak@gentoo.org>

 .../files/sbctl-0.14-installkernel-bashism.patch   | 37 ++++++++++++++++++++++
 .../{sbctl-0.14.ebuild => sbctl-0.14-r1.ebuild}    |  4 +++
 2 files changed, 41 insertions(+)