Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 911261 - net-misc/sslh: Please enable Large File Support (LFS)
Summary: net-misc/sslh: Please enable Large File Support (LFS)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michael Palimaka (kensington)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lfs-tracker
  Show dependency tree
 
Reported: 2023-07-26 18:49 UTC by Allen Webb
Modified: 2023-07-27 11:45 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Allen Webb 2023-07-26 18:49:51 UTC
Here is an example QA check failure:
sslh-1.22c: 12:57:58.009  * QA Notice: The following files were not built with LFS support:
sslh-1.22c: 12:57:58.070  *   Please see https://issuetracker.google.com/201531268 for details.
sslh-1.22c: 12:57:58.125  * fopen /usr/sbin/sslh-fork
sslh-1.22c: 12:57:58.163  * fopen /usr/sbin/sslh-select
sslh-1.22c: 12:57:58.236  * Full build files:
sslh-1.22c: fopen /build/hana/tmp/portage/net-misc/sslh-1.22c/work/sslh-1.22c/common.o
sslh-1.22c: fopen /build/hana/tmp/portage/net-misc/sslh-1.22c/work/sslh-1.22c/sslh-fork
sslh-1.22c: fopen /build/hana/tmp/portage/net-misc/sslh-1.22c/work/sslh-1.22c/sslh-select

I didn't see any usage of off_t that would introduce API breakages with LFS enabled, and it is possible enabling LFS is a no-op for this package because it mainly deals with sockets (which do not using seek), but for completeness I went ahead and filed this.

This patch resolves the issue:
diff --git a/net-misc/sslh/sslh-1.22c.ebuild b/net-misc/sslh/sslh-1.22c.ebuild
index 1c55384e7..04f4780b5 100644
--- a/net-misc/sslh/sslh-1.22c.ebuild
+++ b/net-misc/sslh/sslh-1.22c.ebuild
@@ -38,6 +38,10 @@ src_prepare() {
                Makefile || die
 }
 
+src_configure() {
+       append-lfs-flags
+}
+
 src_compile() {
        # On older versions of GCC, the default gnu89 variant
        # will reject within-for-loop initializers, bug #595426

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-27 11:42:48 UTC
(In reply to Allen Webb from comment #0)
> Here is an example QA check failure:
> sslh-1.22c: 12:57:58.009  * QA Notice: The following files were not built
> with LFS support:
> sslh-1.22c: 12:57:58.070  *   Please see
> https://issuetracker.google.com/201531268 for details.
> sslh-1.22c: 12:57:58.125  * fopen /usr/sbin/sslh-fork
> sslh-1.22c: 12:57:58.163  * fopen /usr/sbin/sslh-select
> sslh-1.22c: 12:57:58.236  * Full build files:
> sslh-1.22c: fopen
> /build/hana/tmp/portage/net-misc/sslh-1.22c/work/sslh-1.22c/common.o
> sslh-1.22c: fopen
> /build/hana/tmp/portage/net-misc/sslh-1.22c/work/sslh-1.22c/sslh-fork
> sslh-1.22c: fopen
> /build/hana/tmp/portage/net-misc/sslh-1.22c/work/sslh-1.22c/sslh-select
> 
> I didn't see any usage of off_t that would introduce API breakages with LFS
> enabled, and it is possible enabling LFS is a no-op for this package because
> it mainly deals with sockets (which do not using seek), but for completeness
> I went ahead and filed this.

FWIW, another reason to need LFS is if doing anything with a file which has a 64-bit inode.

So these bugs aren't as silly as they appear even for socket apps.
Comment 2 Larry the Git Cow gentoo-dev 2023-07-27 11:45:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bcc3644e264bd94c941f10a6a43834b260a4fcea

commit bcc3644e264bd94c941f10a6a43834b260a4fcea
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-07-27 11:45:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-07-27 11:45:28 +0000

    net-misc/sslh: build with LFS
    
    Closes: https://bugs.gentoo.org/911261
    Thanks-to: Allen Webb <allenwebb@google.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/sslh/{sslh-1.22c.ebuild => sslh-1.22c-r1.ebuild} | 4 +++-
 net-misc/sslh/sslh-9999.ebuild                            | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)