Bug 90902 – Cleanup of GLIUtility using the standard process spawn tools and exceptions.

• Status: RESOLVED DUPLICATE of bug 91761
• Product: Gentoo Release Media

[Description Christopher Hotchkiss 2005-04-29 14:15:54 UTC]

get_eth_info: 
Added standard exceptions. 
Rewrote the device check to use is_device. 
Only returns once instead of four times. Throws exceptions instead.
Uses spawn instead of getstatusoutput.

get_value_from_config:
Uses spawn now.
added exception handler

spawn:
folded exitstatus into it. throws exceptions if there is a problem with the run command.

get_uri:
handles spawn exceptions.
uses exceptions
changed 'file' to 'r_file' due to 'file' being a reserved word in 2.4

ping:
uses is_hostname to validate 

spawn_bash:
added a exception handler
still returns status

set_default_route:
added a exception handler

set_ip:
added an exception handler

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Christopher Hotchkiss 2005-04-29 14:16:41 UTC]

Created attachment 57616 [details, diff]
GLIUtility.py

[Comment 2 Christopher Hotchkiss 2005-04-29 14:25:23 UTC]

Created attachment 57617 [details, diff]
Fixed some problems found by pychecker.

[Comment 3 Christopher Hotchkiss 2005-04-29 15:57:17 UTC]

Created attachment 57627 [details, diff]
GLIUtility.py

Made the exceptions more verbose as suggested by antarus.

[Comment 4 Christopher Hotchkiss 2005-05-05 10:09:48 UTC]

Created attachment 58147 [details, diff]
GLIUtility.py.patch

This is the final version of the rewrite.

[Comment 5 Christopher Hotchkiss 2005-05-05 10:11:08 UTC]

Created attachment 58148 [details, diff]
SimpleXMLParser.py.patch

Cleans up the exception code to use GLIException.

[Comment 6 Christopher Hotchkiss 2005-05-06 20:42:27 UTC]

*** This bug has been marked as a duplicate of 91761 ***

[Comment 7 Jeffrey Forman (RETIRED) 2006-03-24 13:46:29 UTC]

Moving to Release Media/Installer.