So upstream okular messed up the USE=-test option again, but this time our patches still apply cleanly so I get a clean cmake error with USE=-test (builds fine with USE=test, still FEATURES=-test), instead of the more usual every-few-months gentoo-level patch application failure. The upstream culprit (emails despammed) is: commit 9f498c7f5 Author: Sune Vuorela <sune@vuo...> AuthorDate: Thu Apr 20 16:17:41 2023 +0200 Commit: Nate Graham <nate@...> CommitDate: Wed Jun 14 17:47:41 2023 +0000 Allow new signatures to have image backgrounds The cmake error is: CMake Error at generators/poppler/CMakeLists.txt:40 (target_compile_definitions): Cannot specify compile definitions for target "imageScalingTest" which is not built by this project. I filed an upstream bug for it at https://bugs.kde.org/show_bug.cgi?id=471173 but then noticed/remembered that gentoo is already applying okular-21.11.80-tests.patch so perhaps upstream isn't receptive to such things and we just update our existing patch to account for the new USE=-test failure as well?
Hmm... no problem now. Without bisecting the fix I suspect upstream 5f2f84457 fixed it (it removes the line named in the error), despite the "never left my computer" wording in its commit entry and the upstream-closed bug saying it was downstream gentoo. RESOLVED/OBSOLETE seems most accurate.
Glad I didn't spend any time on it then.
