Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905780 - www-client/firefox-112.0.2[-jumbo-build] fails to build
Summary: www-client/firefox-112.0.2[-jumbo-build] fails to build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-05 16:44 UTC by Patrick McLean
Modified: 2023-06-06 19:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log, zstd compressed (build.log.zst,530.87 KB, application/octet-stream)
2023-05-05 16:44 UTC, Patrick McLean
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick McLean gentoo-dev 2023-05-05 16:44:08 UTC
Created attachment 861204 [details]
build.log, zstd compressed

20:43.44 rm -f libxul.so
20:43.44 /usr/lib/llvm/15/bin/x86_64-pc-linux-gnu-clang++ -Qunused-arguments -std=gnu++17 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -fno-sized-deallocation -fno-aligned-new -march=znver3 -frecord-gcc-switches -pipe -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pth
read -pipe -frecord-gcc-switches -O3 -fomit-frame-pointer -funwind-tables -DNS_FREE_PERMANENT_DATA=1 -fprofile-generate -DMOZ_PROFILE_INSTRUMENTATION -shared -Wl,-z,defs -Wl,-h,libxul.so -o libxul.so /var/tmp/portage/www-client/firefox-112.0.2/work/firefox_build/instrumented/toolkit/library/build/libxul_so.list   -lpthread -Wl,-O1 -Wl,--as-needed -Wl,--compress-d
ebug-sections=zlib -Wl,-rpath=/usr/lib64/firefox,--enable-new-dtags -fuse-ld=lld -Wl,-z,noexecstack -Wl,-z,text -Wl,-z,relro -Wl,-z,nocopyreloc -Wl,-Bsymbolic-functions -fstack-protector-strong -fstack-clash-protection -Wl,-rpath-link,/var/tmp/portage/www-client/firefox-112.0.2/work/firefox_build/instrumented/dist/bin -Wl,-rpath-link,/usr/lib -fprofile-generate .
./../../js/src/build/libjs_static.a /var/tmp/portage/www-client/firefox-112.0.2/work/firefox_build/instrumented/x86_64-unknown-linux-gnu/release/libgkrust.a ../../../security/sandbox/linux/libmozsandbox.so ../../../config/external/lgpllibs/liblgpllibs.so ../../../config/external/sqlite/libmozsqlite3.so ../../../widget/gtk/mozgtk/libmozgtk.so ../../../widget/gtk/m
ozwayland/libmozwayland.so -Wl,--version-script,symverscript  -licui18n -licuuc -licudata -laom -ldav1d -lasound -lrt -lm -ldl -lX11 -lXcomposite -lXdamage -lXext -lXfixes -lXrandr -lXrender -lXtst -lpthread -lc -lffi -lplds4 -lplc4 -lnspr4 -lz -lssl3 -lsmime3 -lnss3 -lnssutil3 -lfreetype -lfontconfig -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-
1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgraphite2 -lwebpdemux -lwebp -levent -lvpx -lpixman-1 -ldbus-glib-1 -ldbus-1 -lxcb-shm -lX11-xcb -lxcb -lXcursor -lXi
20:46.14 ld.lld: error: undefined hidden symbol: mozilla::a11y::DocAccessible::FireDelayedEvent(unsigned int, mozilla::a11y::LocalAccessible*)
20:46.14 >>> referenced by HTMLSelectAccessible.cpp
20:46.14 >>>               /var/tmp/portage/www-client/firefox-112.0.2/work/firefox_build/instrumented/toolkit/library/build/../../../accessible/html/HTMLSelectAccessible.o:(mozilla::a11y::HTMLSelectOptionAccessible::DOMAttributeChanged(int, nsAtom*, int, nsAttrValue const*, unsigned long))
20:46.15 >>> referenced by HTMLTableAccessible.cpp
20:46.15 >>>               /var/tmp/portage/www-client/firefox-112.0.2/work/firefox_build/instrumented/toolkit/library/build/../../../accessible/html/HTMLTableAccessible.o:(mozilla::a11y::HTMLTableCellAccessible::DOMAttributeChanged(int, nsAtom*, int, nsAttrValue const*, unsigned long))
20:46.15 >>> referenced by HTMLTableAccessible.cpp
20:46.15 >>>               /var/tmp/portage/www-client/firefox-112.0.2/work/firefox_build/instrumented/toolkit/library/build/../../../accessible/html/HTMLTableAccessible.o:(mozilla::a11y::HTMLTableAccessible::DOMAttributeChanged(int, nsAtom*, int, nsAttrValue const*, unsigned long))
20:46.15 >>> referenced 1 more times
20:47.53 clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
Comment 1 Joonas Niilola gentoo-dev 2023-05-06 12:13:07 UTC
Does it work with +jumbo-build? Nothing obvious pops up.
Comment 2 Patrick McLean gentoo-dev 2023-05-08 19:48:02 UTC
(In reply to Joonas Niilola from comment #1)
> Does it work with +jumbo-build? Nothing obvious pops up.

Yes, it works with +jumbo-build
Comment 3 Joonas Niilola gentoo-dev 2023-05-09 05:24:42 UTC
There seem to have been few UNIFIED_BUILD fixes landed for 113.0, please try 113.0 again when it hits the tree hopefully later today.
Comment 4 Kai-Chun Ning 2023-05-16 09:49:25 UTC
I can confirm that with 113.0.1, build still fails without jumbo-build.
Comment 5 Joonas Niilola gentoo-dev 2023-05-16 15:56:54 UTC
Okay, I could reproduce the issue with given flags. Looks like "+clang -jumbo-build +pgo" is the problematic combination. 

+clang +jumbo-build +pgo works
+clang -jumbo-build -pgo works (even with +lto)
-clang -jumbo-build +pgo works.

For the time being to avoid people having compile problems I think I'm going to force jumbo-build on when pgo is specified, maybe even only with clang. I'll see if upstream is interested in fixing this.
Comment 6 mitchellstevens101101 2023-05-22 22:32:38 UTC
I would like to add that -clang -jumbo-build +lto +pgo builds successfully.
Comment 7 Kai-Chun Ning 2023-06-03 09:07:31 UTC
I would like to add that with -clang +jumbo-build +lto +pgo, 113.0.2 builds.
Comment 8 Joonas Niilola gentoo-dev 2023-06-06 17:26:33 UTC
Doing test runs on 114.0 it looks like -jumbo-build has totally broken on this release. There seemed to be plenty of changes to unified builds for this release and we even take a patch from 115 so it is a bit messy. I'll most likely force jumbo-build always on for 114.0.
Comment 9 Larry the Git Cow gentoo-dev 2023-06-06 19:21:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=39cfe283ccf6455b9781e4ac8ac15c9cf9937ed6

commit 39cfe283ccf6455b9781e4ac8ac15c9cf9937ed6
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2023-06-06 19:12:21 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-06-06 19:15:33 +0000

    www-client/firefox: add 114.0
    
     - enable 'valgrind' use flag,
     - include couple upstream skia patches from the upcoming 115 release,
     - increase ulimit in the ebuild when using mold linker and 'lto' use flag so
       the build does not fail.
    
    Bug: https://bugs.gentoo.org/838373
    Closes: https://bugs.gentoo.org/700934
    Closes: https://bugs.gentoo.org/905780
    Closes: https://bugs.gentoo.org/906509
    Closes: https://bugs.gentoo.org/907485
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/Manifest             |  101 +++
 www-client/firefox/firefox-114.0.ebuild | 1445 +++++++++++++++++++++++++++++++
 2 files changed, 1546 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=13fa84f79ee24cb264c37adb0ec54e04a4ba15c4

commit 13fa84f79ee24cb264c37adb0ec54e04a4ba15c4
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2023-06-06 19:19:44 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-06-06 19:19:44 +0000

    profiles/base: package.use.force www-client/firefox[jumbo-build]
    
     - this release seems broken in many ways regarding unified building.
    
    Bug: https://bugs.gentoo.org/905780
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 profiles/base/package.use.force | 5 +++++
 1 file changed, 5 insertions(+)