Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905625 - dev-lang/perl : depend on perl-cleaner even when USE minimal is set
Summary: dev-lang/perl : depend on perl-cleaner even when USE minimal is set
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-05-03 00:59 UTC by gwendal grignou
Modified: 2024-12-21 14:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Update dependency of Perl on perl-cleaner (0001-dev-perl-XML-Parser-Mark-dev-perl-Devel-CheckLib-as-.patch,855 bytes, patch)
2023-05-03 18:19 UTC, gwendal grignou
Details | Diff
Updated patch with proper keyword. (0001-dev-perl-XML-Parser-Mark-dev-perl-Devel-CheckLib-as-.patch,855 bytes, patch)
2023-05-03 18:21 UTC, gwendal grignou
Details | Diff
Update dependency of Perl on perl-cleaner (0001-dev-lang-perl-Upgrade-depedency-on-perl-cleaner.patch,1.28 KB, patch)
2023-05-03 18:23 UTC, gwendal grignou
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description gwendal grignou 2023-05-03 00:59:54 UTC
Upgrading from perl 5.24 to perl 5.36 with an old perl-cleaner (2.20) leaves crumb behing because perl-cleaner --leftovers option does not mark files in /usr/lib64/perl5/vendor_perl/5.36 are orphans.
Older perl-cleaner was expecting them in vendor_perl/5.36.0.

1. make perl-cleaner always a dependency
2. update minmal requirement from 2.5 to 2.30.
Comment 1 gwendal grignou 2023-05-03 18:19:55 UTC
Created attachment 861098 [details, diff]
Update dependency of Perl on perl-cleaner
Comment 2 gwendal grignou 2023-05-03 18:21:40 UTC
Created attachment 861099 [details, diff]
Updated patch with proper keyword.
Comment 3 gwendal grignou 2023-05-03 18:23:57 UTC
Created attachment 861100 [details, diff]
Update dependency of Perl on perl-cleaner

Ignore the first 2 patches.
Comment 4 Larry the Git Cow gentoo-dev 2023-07-15 06:07:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe38b09da732bbee5c7cf411852b04eb76ebb40f

commit fe38b09da732bbee5c7cf411852b04eb76ebb40f
Author:     Gwendal Grignou <gwendal@chromium.org>
AuthorDate: 2023-05-03 17:00:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-07-15 06:03:00 +0000

    dev-lang/perl: Upgrade depedency on perl-cleaner
    
    Update perl ebuild to install a perl-cleaner that understand perl-5.36:
    perl nows install files in /usr/lib*/perl5/5.36, but older perl-cleaner
    expects the data in /usr/lib*/perl5/5.36.0, so it considers the install
    unclean and force reinstall of 5.36 perl packages.
    
    Closes: https://bugs.gentoo.org/905625
    Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
    Closes: https://github.com/gentoo/gentoo/pull/31889
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-lang/perl/{perl-5.36.1-r2.ebuild => perl-5.36.1-r3.ebuild} | 2 +-
 dev-lang/perl/{perl-5.38.0.ebuild => perl-5.38.0-r1.ebuild}    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2024-05-28 00:57:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=32499b48da6ebacee94f4c84e49a145beb681d11

commit 32499b48da6ebacee94f4c84e49a145beb681d11
Author:     Matt Jolly <kangie@gentoo.org>
AuthorDate: 2024-05-26 01:52:15 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-28 00:56:36 +0000

    app-admin/perl-cleaner: dev-lang/perl from PDEPEND -> RDEPEND
    
    This commit effectively reverts 00aadd9b5059a0675edb18cbb3278059b987ed24 as
    the combination of that change with
    fe38b09da732bbee5c7cf411852b04eb76ebb40f's changes to dev-lang/perl's
    dependencies result in circular dependencies in prefix.
    
    ```
    (dev-lang/perl-5.38.2-r5:0/5.38::gentoo, ebuild scheduled for merge) depends on
     (app-admin/perl-cleaner-2.31-r1:0/0::gentoo, ebuild scheduled for merge) (runtime)
      (sys-apps/portage-3.0.64-r2:0/0::gentoo, ebuild scheduled for merge) (runtime)
       (app-admin/eselect-1.4.27-r1:0/0::gentoo, ebuild scheduled for merge) (runtime)
        (sys-apps/coreutils-9.5:0/0::gentoo, ebuild scheduled for merge) (buildtime)
         (dev-lang/perl-5.38.2-r5:0/5.38::gentoo, ebuild scheduled for merge) (buildtime)
    ```
    
    [sam: Added some detail to commit message, revbumped too.]
    
    Bug: https://bugs.gentoo.org/932348
    Bug: https://bugs.gentoo.org/905625
    Bug: https://bugs.gentoo.org/915046
    Signed-off-by: Matt Jolly <kangie@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/36818
    Signed-off-by: Sam James <sam@gentoo.org>

 .../{perl-cleaner-2.31-r1.ebuild => perl-cleaner-2.31-r2.ebuild}        | 2 +-
 app-admin/perl-cleaner/perl-cleaner-9999.ebuild                         | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=52013a947b62f88873a924a8cd7adb69af66c3b9

commit 52013a947b62f88873a924a8cd7adb69af66c3b9
Author:     Matt Jolly <kangie@gentoo.org>
AuthorDate: 2024-05-26 01:46:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-28 00:54:21 +0000

    dev-lang/perl: PDEPEND on perl-cleaner if USE !minimal
    
    This change effectively reverts fe38b09da732bbee5c7cf411852b04eb76ebb40f
    as the combination of moving perl-cleaner to IDEPEND after this
    and 00aadd9b5059a0675edb18cbb3278059b987ed24 moving
    dev-lang/perl from RDEPEND -> PDEPEND in perl-cleaner results in circular dependencies.
    
    ```
    (dev-lang/perl-5.38.2-r5:0/5.38::gentoo, ebuild scheduled for merge) depends on
     (app-admin/perl-cleaner-2.31-r1:0/0::gentoo, ebuild scheduled for merge) (runtime)
      (sys-apps/portage-3.0.64-r2:0/0::gentoo, ebuild scheduled for merge) (runtime)
       (app-admin/eselect-1.4.27-r1:0/0::gentoo, ebuild scheduled for merge) (runtime)
        (sys-apps/coreutils-9.5:0/0::gentoo, ebuild scheduled for merge) (buildtime)
         (dev-lang/perl-5.38.2-r5:0/5.38::gentoo, ebuild scheduled for merge) (buildtime)
    
    It might be possible to break this cycle
    by applying any of the following changes:
    - app-admin/perl-cleaner-2.31-r1 (Change USE: +pkgcore)
    - sys-apps/portage-3.0.64-r2 (Change USE: +build)
    ```
    
    [sam: Added some detail to commit message, revbumped too.]
    
    Bug: https://bugs.gentoo.org/932348
    Bug: https://bugs.gentoo.org/905625
    Bug: https://bugs.gentoo.org/915046
    Signed-off-by: Matt Jolly <kangie@gentoo.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-lang/perl/perl-5.38.2-r6.ebuild                | 865 +++++++++++++++++++++
 ...5.40.0_rc1.ebuild => perl-5.40.0_rc1-r1.ebuild} |   3 +-
 2 files changed, 867 insertions(+), 1 deletion(-)
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-28 00:59:52 UTC
Had to revert this because of bug 915046 and then bug 932348 from where I tried to fix the former.

Does USE=minimal not work for you?