Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 898660 - net-libs/libhtp-0.5.43 has implicit function declarations in configure logs
Summary: net-libs/libhtp-0.5.43 has implicit function declarations in configure logs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 906027
  Show dependency tree
 
Reported: 2023-03-02 07:47 UTC by Agostino Sarubbo
Modified: 2023-05-09 13:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,90.10 KB, text/plain)
2023-03-02 07:47 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-03-02 07:47:49 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-libs/libhtp-0.5.42 has implicit function declarations in configure logs.
Discovered on: amd64 (internal ref: ci)

NOTE:
See also: https://bugs.gentoo.org/898488#c4.
Comment 1 Agostino Sarubbo gentoo-dev 2023-03-02 07:47:51 UTC
Created attachment 855510 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-04-17 07:41:25 UTC
ci has reproduced this issue with version 0.5.43 - Updating summary.
Comment 3 Marek Szuba archtester gentoo-dev 2023-04-17 15:54:52 UTC
Is there a way of telling QA not to complain about this? There are no additional header files to include here, what this test does is tell apart dev-libs/libiconv (which does define iconvctl()) from other iconv providers (which do not). As such, the test in question is supposed to fail in most cases (both glibc and musl provide iconv so I think we would only ever pull in dev-libs/libiconv in Prefix installations?) and having the failure occur at compile rather than at link time is if anything desirable.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-09 13:22:00 UTC
(In reply to Marek Szuba from comment #3)
> Is there a way of telling QA not to complain about this? There are no
> additional header files to include here, what this test does is tell apart
> dev-libs/libiconv (which does define iconvctl()) from other iconv providers
> (which do not). As such, the test in question is supposed to fail in most
> cases (both glibc and musl provide iconv so I think we would only ever pull
> in dev-libs/libiconv in Prefix installations?) and having the failure occur
> at compile rather than at link time is if anything desirable.

See first comment:
>See also: https://bugs.gentoo.org/898488#c4.
Comment 5 Marek Szuba archtester gentoo-dev 2023-05-09 13:24:02 UTC
(In reply to Sam James from comment #4)

> See first comment:
> >See also: https://bugs.gentoo.org/898488#c4.

YOUR first comment, I presume. Thanks!
Comment 6 Larry the Git Cow gentoo-dev 2023-05-09 13:34:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a3a05946d75eeabb47f18fdb528f04df27911d6e

commit a3a05946d75eeabb47f18fdb528f04df27911d6e
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2023-05-09 13:28:53 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2023-05-09 13:34:05 +0000

    net-libs/libhtp: have QA ignore implicit 'iconvctl' declaration in configure
    
    The only iconv provider which defines iconvctl() is dev-libs/libiconv,
    which is only needed in certain Prefix installations. As such, this
    test is very much *intended* to fail to locate the function in question
    in the vast majority of cases.
    
    Closes: https://bugs.gentoo.org/898660
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 net-libs/libhtp/libhtp-0.5.43.ebuild | 4 ++++
 1 file changed, 4 insertions(+)