Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 881965 - app-admin/pwgen-2.08-r1 fails to compile (CLANG-STRICTER-SYSTEM): sha1.c:45:6: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
Summary: app-admin/pwgen-2.08-r1 fails to compile (CLANG-STRICTER-SYSTEM): sha1.c:45:6...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Julian Simioni
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: c23-porting
  Show dependency tree
 
Reported: 2022-11-19 08:33 UTC by Agostino Sarubbo
Modified: 2023-04-21 13:00 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,52.74 KB, text/plain)
2022-11-19 08:33 UTC, Agostino Sarubbo 		Details
c2x patch (pwgen-c2x.patch,1.50 KB, patch)
2023-04-20 12:52 UTC, Fabian Groffen 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-11-19 08:33:53 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-admin/pwgen-2.08-r1 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types -Werror=deprecated-non-prototype

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
Comment 1 Agostino Sarubbo gentoo-dev 2022-11-19 08:33:56 UTC 
Created attachment 833601 [details]
build.log

build log and emerge --info
Comment 2 Fabian Groffen gentoo-dev 2023-04-20 12:52:10 UTC 
Created attachment 860431 [details, diff]
c2x patch

forcing -std=gnu2x with gcc-12.2.1 produces the same warnings.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-04-20 16:08:52 UTC 
(In reply to Fabian Groffen from comment #2)
> Created attachment 860431 [details, diff] [details, diff]
> c2x patch
> 
> forcing -std=gnu2x with gcc-12.2.1 produces the same warnings.

feel free to apply it, thanks!
Comment 4 Larry the Git Cow gentoo-dev 2023-04-21 13:00:49 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=08669acd9eac3a9ea64fb177c0c8cf706843c1c0

commit 08669acd9eac3a9ea64fb177c0c8cf706843c1c0
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2023-04-21 12:58:52 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2023-04-21 12:59:42 +0000

    app-admin/pwgen-2.08-r2: fix c2x errors
    
    Closes: https://bugs.gentoo.org/881965
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 app-admin/pwgen/files/pwgen-2.08-c2x.patch | 62 ++++++++++++++++++++++++++++++
 app-admin/pwgen/pwgen-2.08-r2.ebuild       | 27 +++++++++++++
 2 files changed, 89 insertions(+)