Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 881957 - app-admin/gkrellm-2.3.11-r1 fails to compile (CLANG-STRICTER-SYSTEM): mail.c:551:23: error: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
Summary: app-admin/gkrellm-2.3.11-r1 fails to compile (CLANG-STRICTER-SYSTEM): mail.c:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: c23-porting
  Show dependency tree
 
Reported: 2022-11-19 08:31 UTC by Agostino Sarubbo
Modified: 2023-02-03 09:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,48.69 KB, text/plain)
2022-11-19 08:31 UTC, Agostino Sarubbo 		Details
Declare arguments on function pointers to solve clang stricter warnings (0001-Declare-arguments-on-function-pointers.patch,17.62 KB, patch)
2023-01-28 00:50 UTC, A Schenck 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-11-19 08:31:08 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-admin/gkrellm-2.3.11-r1 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types -Werror=deprecated-non-prototype

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
Comment 1 Agostino Sarubbo gentoo-dev 2022-11-19 08:31:11 UTC 
Created attachment 833593 [details]
build.log

build log and emerge --info
Comment 2 A Schenck 2023-01-28 00:50:41 UTC 
Created attachment 849311 [details, diff]
Declare arguments on function pointers to solve clang stricter warnings

Builds, runs, and at least gkrelltop plugin still works locally.
Comment 3 A Schenck 2023-01-28 00:53:28 UTC 
Haven't been able to subscribe to upstream mailing list to post the patch, working on finding some other way.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-03 09:58:49 UTC 
(In reply to A Schenck from comment #3)
> Haven't been able to subscribe to upstream mailing list to post the patch,
> working on finding some other way.

Thanks. Could you send it https://git.srcbox.net/gkrellm/gkrellm/pulls?
Comment 5 Larry the Git Cow gentoo-dev 2023-02-03 09:59:56 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=01e3da75ac69c4e0b67ec637cf0af31f9cc37dc7

commit 01e3da75ac69c4e0b67ec637cf0af31f9cc37dc7
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-02-03 09:59:07 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-03 09:59:07 +0000

    app-admin/gkrellm: fix various warnings
    
    Closes: https://bugs.gentoo.org/881957
    Thanks-to: A Schenck <galiven@users.sourceforge.net>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../gkrellm/files/gkrellm-2.3.11-clang16.patch     | 540 +++++++++++++++++++++
 app-admin/gkrellm/gkrellm-2.3.11-r3.ebuild         | 142 ++++++
 2 files changed, 682 insertions(+)