Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 881355 - net-vpn/iodine-0.7.0-r3: init script has no mechanism for -c, -d, etc.
Summary: net-vpn/iodine-0.7.0-r3: init script has no mechanism for -c, -d, etc.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jason A. Donenfeld
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-11-15 02:01 UTC by Hank Leininger
Modified: 2022-12-03 01:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hank Leininger 2022-11-15 02:01:38 UTC
There are a few options one might need to pass to iodined that /etc/{init.d,conf.d}/iodined can't support, such as:

       -d device  Use the TUN device 'device' instead of the normal one...

       -c  Disable checking the client IP address on all incoming requests

       -i max_idle_time  stop the server after this much idle time

I don't think it's worth endlessly extending the list of specific variables; I propose we just add a IODINED_ARGS for site-specific extensions, as various other conf.d/init.d scripts do.

Will submit a PR.
Comment 1 Larry the Git Cow gentoo-dev 2022-12-03 01:37:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c24f1f933c3c5264da5ab53d4f74afc0fa037965

commit c24f1f933c3c5264da5ab53d4f74afc0fa037965
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2022-11-15 04:12:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-03 01:35:27 +0000

    net-vpn/iodine: Add support for arbitrary args in conf.d/iodined
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/881355
    Closes: https://github.com/gentoo/gentoo/pull/28276
    Signed-off-by: Sam James <sam@gentoo.org>

 net-vpn/iodine/files/iodined-1.init-r1 | 64 ++++++++++++++++++++++++++++++++++
 net-vpn/iodine/files/iodined.conf-r1   | 46 ++++++++++++++++++++++++
 net-vpn/iodine/iodine-0.7.0-r4.ebuild  | 50 ++++++++++++++++++++++++++
 3 files changed, 160 insertions(+)