Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 879665 - dev-libs/keystone: possible configure breakage with Clang 16
Summary: dev-libs/keystone: possible configure breakage with Clang 16
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: mario.haustein
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 906027
  Show dependency tree
 
Reported: 2022-11-04 22:09 UTC by Matt Jolly
Modified: 2024-01-08 13:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
clang-14.log (clang-14.log,15.19 KB, text/plain)
2022-11-04 22:09 UTC, Matt Jolly
Details
clang-15.log (clang-15.log,15.14 KB, text/plain)
2022-11-04 22:09 UTC, Matt Jolly
Details
clang.diff (clang.diff,21.48 KB, text/plain)
2022-11-04 22:09 UTC, Matt Jolly
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Jolly gentoo-dev 2022-11-04 22:09:28 UTC
This package has been identified via automation as potentially impacted by upcoming Clang 16 changes.
The following have been identified as potential issues:

[-Werror,-Wstrict-prototypes]

[-Werror,-Wstrict-prototypes]
error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
Comment 1 Matt Jolly gentoo-dev 2022-11-04 22:09:29 UTC
Created attachment 827249 [details]
clang-14.log

build log
Comment 2 Matt Jolly gentoo-dev 2022-11-04 22:09:30 UTC
Created attachment 827251 [details]
clang-15.log

build log
Comment 3 Matt Jolly gentoo-dev 2022-11-04 22:09:32 UTC
Created attachment 827253 [details]
clang.diff

build log
Comment 4 mario.haustein 2022-11-29 15:24:50 UTC
(In reply to Matt Jolly from comment #0)
> This package has been identified via automation as potentially impacted by
> upcoming Clang 16 changes.
> The following have been identified as potential issues:
> 
> [-Werror,-Wstrict-prototypes]
> 
> [-Werror,-Wstrict-prototypes]
> error: a function declaration without a prototype is deprecated in all
> versions of C [-Werror,-Wstrict-prototypes]

Could you please provide a hint how to reproduce this issue? I tried with

# CC=clang CXX=clang++ CXXFLAGS="-Werror=strict-prototypes" CFLAGS="-Werror=strict-prototypes" emerge =dev-libs/keystone-0.9.2-r1

in a virtual machine, but wasn't able reproduce the error.


# emerge --info
Portage 3.0.38.1 (python 3.10.8-final-0, default/linux/amd64/17.1, gcc-11.3.0, glibc-2.35-r8, 5.15.74-gentoo x86_64)
=================================================================
System uname: Linux-5.15.74-gentoo-x86_64-Intel-R-_Core-TM-_i7-7500U_CPU_@_2.70GHz-with-glibc2.35
KiB Mem:    16274764 total,   4358056 free
KiB Swap:          0 total,         0 free
sh bash 5.1_p16-r2
ld GNU ld (Gentoo 2.38 p4) 2.38
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.1_p16-r2::gentoo
dev-lang/perl:             5.34.1-r4::gentoo
dev-lang/python:           3.10.8_p3::gentoo, 3.11.0_p2::gentoo
dev-util/cmake:            3.24.3::gentoo
dev-util/meson:            0.63.2-r1::gentoo
sys-apps/baselayout:       2.8::gentoo
sys-apps/openrc:           0.45.2-r1::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-devel/autoconf:        2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           15.0.5::gentoo
sys-devel/gcc:             11.3.0::gentoo
sys-devel/gcc-config:      2.8::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/llvm:            14.0.6-r2::gentoo, 15.0.5::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.15-r3::gentoo (virtual/os-headers)
sys-libs/glibc:            2.35-r8::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="C.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j4"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl amd64 bzip2 cli crypt dri fortran gdbm iconv ipv6 libglvnd libtirpc multilib ncurses nls nptl openmp pam pcre readline seccomp split-usr ssl test-rust unicode xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SHELL, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 5 Joonas Niilola gentoo-dev 2022-12-29 19:00:33 UTC
(In reply to mario.haustein from comment #4)
> (In reply to Matt Jolly from comment #0)
> > This package has been identified via automation as potentially impacted by
> > upcoming Clang 16 changes.
> > The following have been identified as potential issues:
> > 
> > [-Werror,-Wstrict-prototypes]
> > 
> > [-Werror,-Wstrict-prototypes]
> > error: a function declaration without a prototype is deprecated in all
> > versions of C [-Werror,-Wstrict-prototypes]
> 
> Could you please provide a hint how to reproduce this issue? I tried with
> 
> # CC=clang CXX=clang++ CXXFLAGS="-Werror=strict-prototypes"
> CFLAGS="-Werror=strict-prototypes" emerge =dev-libs/keystone-0.9.2-r1
> 
> in a virtual machine, but wasn't able reproduce the error.
> 
> 

Hey, 

please see the tracker bug.
https://bugs.gentoo.org/870412#c0
https://bugs.gentoo.org/870412#c1

although reproducing does take a bit of portage knowledge and tinkering. Please try to check upstream if they're already working on this.
Comment 6 Joonas Niilola gentoo-dev 2022-12-29 19:02:41 UTC
And as a general info page there's https://wiki.gentoo.org/wiki/Modern_C_porting
Comment 7 mario.haustein 2023-10-08 12:09:17 UTC
I was still not able to reproduce this actual issue, but spotted some deprecated prototypes and submitted a patch upstream.
Comment 8 Larry the Git Cow gentoo-dev 2024-01-08 13:50:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=578daf3796eefa3981d9e97374cf0c529b4c7fcc

commit 578daf3796eefa3981d9e97374cf0c529b4c7fcc
Author:     Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
AuthorDate: 2023-10-08 12:07:29 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-01-08 13:50:35 +0000

    dev-libs/keystone: fix modern C issue
    
    Closes: https://bugs.gentoo.org/879665
    Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../files/keystone-0.9.2-strict-prototypes.patch   | 156 +++++++++++++++++++++
 dev-libs/keystone/keystone-0.9.2-r3.ebuild         | 100 +++++++++++++
 2 files changed, 256 insertions(+)