Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 879533 - dev-libs/libstrophe-0.12.2 fails to build with /bin/sh -> dash
Summary: dev-libs/libstrophe-0.12.2 fails to build with /bin/sh -> dash
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Adrian Schollmeyer
URL: https://github.com/strophe/libstrophe...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: nonbash
  Show dependency tree
 
Reported: 2022-11-04 09:17 UTC by Anna Vyalkova
Modified: 2023-05-02 22:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
link.log (link.log,20.12 KB, text/x-log)
2022-11-04 09:17 UTC, Anna Vyalkova
Details
build.log (libstrophe-build.log,108.07 KB, text/plain)
2022-11-04 17:27 UTC, Anna Vyalkova
Details
config.log (config.log,45.03 KB, text/plain)
2022-11-04 17:28 UTC, Anna Vyalkova
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Vyalkova 2022-11-04 09:17:09 UTC
Created attachment 826965 [details]
link.log

Lots of "undefined references". But if I add "-lgnutls" to LDFLAGS, it works.
Comment 1 Anna Vyalkova 2022-11-04 09:18:46 UTC
I'd try append-libs from flag-o-matic.eclass
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-04 16:44:04 UTC
Missing the full build.log and emerge --info.
Comment 3 Anna Vyalkova 2022-11-04 17:27:48 UTC
Created attachment 827099 [details]
build.log
Comment 4 Anna Vyalkova 2022-11-04 17:28:36 UTC
Created attachment 827101 [details]
config.log

Ah, it fails to find gnutls
Comment 5 Anna Vyalkova 2022-11-04 17:37:55 UTC
> ./configure: 14622: test: xyes: unexpected operator
> ./configure: 14716: test: x: unexpected operator

The test is:

> if test "x$enable_tls" != xno -a "x$with_gnutls" == xyes

But it isn't POSIX so dash (my /bin/sh) doesn't support it.
Comment 6 Adrian Schollmeyer 2022-11-05 18:44:11 UTC
This is the same problem as https://bugs.gentoo.org/877049, just with a different error. I'll wait for upstream to respond to Anna's PR and then backport the fix.
Comment 7 Larry the Git Cow gentoo-dev 2022-11-06 11:07:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca475f37660c940516572a8c4eee6ec0e017c0f1

commit ca475f37660c940516572a8c4eee6ec0e017c0f1
Author:     Adrian Schollmeyer <nex+b-g-o@nexadn.de>
AuthorDate: 2022-11-05 19:23:46 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2022-11-06 11:04:24 +0000

    dev-libs/libstrophe: Backport /bin/sh -> dash fix
    
    Closes: https://bugs.gentoo.org/877049
    Closes: https://bugs.gentoo.org/879533
    Signed-off-by: Adrian Schollmeyer <nex+b-g-o@nexadn.de>
    Closes: https://github.com/gentoo/gentoo/pull/28148
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 dev-libs/libstrophe/Manifest                 |  1 +
 dev-libs/libstrophe/libstrophe-0.12.2.ebuild | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
Comment 8 Larry the Git Cow gentoo-dev 2023-05-02 22:53:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=191fbdaf985652a3873a545226a53cc2ad37de41

commit 191fbdaf985652a3873a545226a53cc2ad37de41
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-02 22:50:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-02 22:53:12 +0000

    dev-libs/libstrophe: avoid maintainer mode b/c of bashisms patch
    
    The bashisms patch touches configure.ac so it causes maintainer mode
    in src_compile. Run eautoreconf instead.
    
    Bug: https://bugs.gentoo.org/877049
    Bug: https://bugs.gentoo.org/879533
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/libstrophe/libstrophe-0.12.2.ebuild | 11 +++++++++++
 1 file changed, 11 insertions(+)