Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 877079 - net-libs/gnet-2.0.8-r4 fails tests (lto): gnethash.c:60:18: error: invalid storage class for function test_sha1
Summary: net-libs/gnet-2.0.8-r4 fails tests (lto): gnethash.c:60:18: error: invalid st...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-10-14 06:59 UTC by Agostino Sarubbo
Modified: 2022-11-14 15:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,534.13 KB, text/plain)
2022-10-14 06:59 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-10-14 06:59:46 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-libs/gnet-2.0.8-r4 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-10-14 06:59:50 UTC
Created attachment 824025 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2022-10-14 17:03:36 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80831935563c8af13b20f019bd706b0bc5653b0a

commit 80831935563c8af13b20f019bd706b0bc5653b0a
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-10-14 16:51:00 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-10-14 17:03:22 +0000

    profiles: Mask net-libs/gnet for removal
    
    Bug: https://bugs.gentoo.org/349301
    Bug: https://bugs.gentoo.org/713152
    Bug: https://bugs.gentoo.org/802723
    Bug: https://bugs.gentoo.org/808435
    Bug: https://bugs.gentoo.org/870730
    Bug: https://bugs.gentoo.org/877079
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2022-11-14 15:11:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9a9c062bf8e328aac84825b9c265a8d1e1d1781f

commit 9a9c062bf8e328aac84825b9c265a8d1e1d1781f
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-11-13 13:34:42 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-11-14 15:11:25 +0000

    net-libs/gnet: Delete
    
    Closes: https://bugs.gentoo.org/349301
    Closes: https://bugs.gentoo.org/713152
    Closes: https://bugs.gentoo.org/802723
    Closes: https://bugs.gentoo.org/808435
    Closes: https://bugs.gentoo.org/870730
    Closes: https://bugs.gentoo.org/877079
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 net-libs/gnet/Manifest                             |  1 -
 net-libs/gnet/files/gnet-2.0.8-autotools.patch     | 37 -------------
 .../gnet/files/gnet-2.0.8-check-usage-update.patch | 35 ------------
 net-libs/gnet/files/gnet-2.0.8-context-leak.patch  | 32 -----------
 .../files/gnet-2.0.8-fix-pkgconfig-abuse.patch     | 16 ------
 net-libs/gnet/files/gnet-2.0.8-network-tests.patch | 32 -----------
 .../files/gnet-2.0.8-test-existing-domain.patch    | 32 -----------
 .../gnet/files/gnet-2.0.8-unittest-build.patch     | 22 --------
 .../gnet/files/gnet-2.0.8-unittest-service.patch   | 31 -----------
 net-libs/gnet/gnet-2.0.8-r4.ebuild                 | 62 ----------------------
 net-libs/gnet/metadata.xml                         |  8 ---
 profiles/package.mask                              |  7 ---
 12 files changed, 315 deletions(-)