Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 876800 - sys-apps/fwupd: Remove net-libs/libsoup dependency
Summary: sys-apps/fwupd: Remove net-libs/libsoup dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-11 21:13 UTC by Matt Turner
Modified: 2022-12-08 15:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2022-10-11 21:13:09 UTC
With the transition to libsoup:3.0, I noticed fwupd depends on libsoup:2.4 (specifically >=net-libs/libsoup-2.51.92:2.4[introspection?]), but... 

(1) the build system doesn't check for it
(2) soup.h is never #included, and
(3) the libsoup dependency was removed and replaced with libcurl in

https://github.com/fwupd/fwupd/commit/3a73c342ba0874fb79a390bcbcb5fb79e8529b39

first in fwupd v1.5.2.

It looks like if the meson option soup_session_compat is enabled (which it is, by default, and we don't change it in the ebuild) fwupd builds some code that dlopens libsoup-2.4.so.1 at runtime. That sounds like an optfeature to me.

I also see no evidence for the the [introspection?] USE-dep.
Comment 1 Larry the Git Cow gentoo-dev 2022-10-13 09:31:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e89e16b3dee3e6d2a5c08356df6c1f9abf023439

commit e89e16b3dee3e6d2a5c08356df6c1f9abf023439
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2022-10-13 09:16:55 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2022-10-13 09:31:08 +0000

    sys-apps/fwupd: add 1.8.6
    
    Closes: https://bugs.gentoo.org/876800
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 sys-apps/fwupd/Manifest                            |   1 +
 .../fwupd/files/fwupd-1.8.6-installed_tests.patch  | 357 +++++++++++++++++++++
 sys-apps/fwupd/fwupd-1.8.6.ebuild                  | 204 ++++++++++++
 3 files changed, 562 insertions(+)