https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-radio/tlf-1.4.1-r1 fails tests (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 823357 [details] build.log build log and emerge --info
Seems -flto does not play well with -Wl,--wrap= used in test code here. Will filter out -flto.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=06218fe92fee66e591a571752a18b2e35ce66419 commit 06218fe92fee66e591a571752a18b2e35ce66419 Author: Thomas Beierlein <tomjbe@gentoo.org> AuthorDate: 2022-10-23 16:21:04 +0000 Commit: Thomas Beierlein <tomjbe@gentoo.org> CommitDate: 2022-10-23 16:21:42 +0000 media-radio/tlf: Drop -flto and fix some warnings Closes: https://bugs.gentoo.org/876418 Signed-off-by: Thomas Beierlein <tomjbe@gentoo.org> media-radio/tlf/files/tlf-1.4.1-missing-include.patch | 10 ++++++++++ media-radio/tlf/tlf-1.4.1-r1.ebuild | 2 ++ 2 files changed, 12 insertions(+)
