Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 87553 - gimpshop-2.2.4.ebuild - New ebuild for gimpshop
Summary: gimpshop-2.2.4.ebuild - New ebuild for gimpshop
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Lowest enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
: 103283 107615 121591 157556 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-04-01 05:33 UTC by Olivier Tarnus
Modified: 2008-02-21 21:47 UTC (History)
12 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
First ebuild for gimpshop (this is my first ebuild too... You've been warned!) (gimpshop-2.2.4.ebuild,3.73 KB, application/octet-stream)
2005-04-01 05:37 UTC, Olivier Tarnus
Details
gimp-2.2.4.ebuild with gimpshop (gimp-2.2.4.ebuild,3.65 KB, text/plain)
2005-04-05 12:28 UTC, Sebastian Wramba
Details
gimp-2.2.4-gimpshop.patch (gimp-2.2.4-gimpshop.patch,126.80 KB, patch)
2005-04-05 12:29 UTC, Sebastian Wramba
Details | Diff
ltmain_sh-1.5.0-fix-relink.patch (ltmain_sh-1.5.0-fix-relink.patch,1.68 KB, patch)
2005-04-05 12:29 UTC, Sebastian Wramba
Details | Diff
diff from media-gfx/gimp-2.2.8-r1 (gimp-2.2.8-r2.diff,1.54 KB, patch)
2005-12-28 18:09 UTC, fabien Zouaoui
Details | Diff
gimpshop-2.2.10.ebuild (gimpshop-2.2.10.ebuild,3.83 KB, text/plain)
2006-02-08 23:32 UTC, Beech Horn
Details
gimpshop 2.2.11 (gimpshop-2.2.11.ebuild,3.99 KB, text/plain)
2006-09-25 14:07 UTC, mathe
Details
patch to libpng >=1.2.10 (gimpshop-2.2.11-libpng-1.2.10.patch,571 bytes, patch)
2006-09-25 14:08 UTC, mathe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Tarnus 2005-04-01 05:33:52 UTC
Please find attached a new ebuild for gimpshop (derived from gimp's ebuild).

Gimpshop is a hack of the gimp to provide an interface more close to Adboe Photoshop  (see http://plasticbugs.com/).

I'm not a portage specialist, so some part of the ebuild are clearly not "clean". Can someone tidy this 2 things:

 -The source package is actually has a .tbz extension. This is not recognized by unpack, so you MUST download and rename the file "manually" to a .tar.bz2 (i can't find a way to do this in my ebuild)
 -When unpacking the source, it creates a "gimp-2.2.4" and not "gimpshop-2.2.4" so i do also rename manually

Except this, build seems to be fine.

I've added an exclusion to gimp to avoid problems. So you CAN'T actually have both gimp and gimpshop. It would be better to patch the source to get install in an alternative directory (for ex /opt/gimpshop as proposed at http://forums.gentoo.org/viewtopic-t-317274-highlight-gimpshop.html).

Reproducible: Always
Steps to Reproduce:
install...
build...
run... hopefully :-)
Actual Results:  
Everything seems fine.

Expected Results:  
nothing
Comment 1 Olivier Tarnus 2005-04-01 05:37:32 UTC
Created attachment 55028 [details]
First ebuild for gimpshop (this is my first ebuild too... You've been warned!)

Definitely need cleaning. Please download the package first and rename to
".tar.bz2" instead of ".tbz" or it won't work...
Comment 2 James P. Barrett 2005-04-01 14:28:32 UTC
It seems to me that a better way of handling gimpshop would be as an option for the gimp-2.4.4.ebuild controlled by a package-specific USE variable "gimpshop". You'd need a patch file to transform the raw gimp source into the gimpshop source, but diff should produce that easily enough.
Comment 3 R!tman 2005-04-03 01:19:04 UTC
I did exactly what James P. Barrett suggested. 

The ebuild is here:
http://n.ethz.ch/student/homartin/download/gimp-2.2.4.ebuild
Comment 4 Sebastian Wramba 2005-04-05 12:28:37 UTC
Created attachment 55389 [details]
gimp-2.2.4.ebuild with gimpshop

This is the gimp-2.2.4.ebuild by Martin Hoffmann (big thanks!) with some
corrections. The ltmain.sh- and the gimpshop-patch must be manually downloaded
into the /usr/local/portage/media-gfx/gimp/files/ directory.
Comment 5 Sebastian Wramba 2005-04-05 12:29:23 UTC
Created attachment 55390 [details, diff]
gimp-2.2.4-gimpshop.patch
Comment 6 Sebastian Wramba 2005-04-05 12:29:48 UTC
Created attachment 55391 [details, diff]
ltmain_sh-1.5.0-fix-relink.patch
Comment 7 Sebastian Wramba 2005-04-05 13:00:25 UTC
Comment on attachment 55389 [details]
gimp-2.2.4.ebuild with gimpshop

I also removed the pygimp-logo-thing, not necessary anymore, because the logo
is included in the 2.2.4 source.
Comment 8 R!tman 2005-04-05 13:24:01 UTC
As the ebuild is right now, the patches do not have to be downloaded or copied seperately!

The ebuild manages that, but the patches are downloaded to the distfiles directory. I did not manage to get the patch files (or better said only the 4k big ltmain_sh-1.5.0-fix-relink.patch) to the files directory. As I heard, this is not possible. 

Btw, the gimpshop.patch is 128k and should therefore not be in ${FILESDIR}. But, as we are talking about the overlay emerge sync will not influence it. 

So, after some emailing with Sebastian Wramba, I decided to change the ebuild in a way, so that the patchfiles have to be copied to gimp's overlay files directory _manually_, as it seems this is the preferable way of making overlay ebuild.

Apologies, this is my first ebuild, I wanted to make life for people easier!

The 'fixed' ebuild is online NOW!
Comment 9 Joe McCann (RETIRED) gentoo-dev 2005-04-05 20:11:28 UTC
I don't believe it is right to add this to portage in its current state. It isn't officially supported by upstream gimp authors, its still in an early state of development, no clue what sort of support if any comes from the patch author, and there really isn't enough dev power to split and track this. 

This doesn't meet any of the requirements for addnig a features patch. Also the message on the front page of the site stating I am not a programmer and went about this hack in the totally wrong way isn't exactly comforting for me.
Comment 10 R!tman 2005-04-10 13:08:58 UTC
Here are TWO ebuilds from two different people. And not both say the ebuild is a hack. 

In fact, I changed only some letters and added one line to the gimp-2.2.3.ebuild. 

The only thing different to 2.2.3, except from installing 2.2.4 instead of 2.2.3, is to apply a patch.
Comment 11 Jakub Moc (RETIRED) gentoo-dev 2005-08-23 18:00:43 UTC
*** Bug 103283 has been marked as a duplicate of this bug. ***
Comment 12 David Grant 2005-09-16 09:08:39 UTC
gimpshop just made slashdot again today.

this program is much more stable than most masked packages.
Comment 13 Luca Barbato gentoo-dev 2005-09-16 11:18:49 UTC
Sorry, nobody has time to test it now and isn't really of primary importance

cinelerra made slashdot but isn't in portage since is too problematic.

Given that gimp has a theme feature it could be exploited to add that look and
feel or extended to allow that. If you proponents have enough time you should
have a look and try that way..
Comment 14 David Grant 2005-09-16 18:35:13 UTC
Luca, who are you speaking on behalf of when you say that no one has time to
test it now?
Comment 15 Luca Barbato gentoo-dev 2005-09-16 19:56:02 UTC
gnome and graphics herd are currently swamped with other issues 

Hopefully one of our osx devs may have enough time to test it.

Anyway don't hold your breath yet.
Comment 16 Kito (RETIRED) gentoo-dev 2005-09-16 20:17:41 UTC
This version of gimp isn't in the tree anymore. Submitting a cleaner patch against a current gimp ebuild 
might speed this up a little. 

Not exactly a trivial patch, keeping upstream gimp and the gimpshop patch in sync via portage could 
prove to be quite time consuming maintenance-wise...
Comment 17 Carsten Lohrke (RETIRED) gentoo-dev 2005-09-29 09:13:21 UTC
*** Bug 107615 has been marked as a duplicate of this bug. ***
Comment 18 fabien Zouaoui 2005-12-28 18:09:59 UTC
Created attachment 75697 [details, diff]
diff from media-gfx/gimp-2.2.8-r1

hi,
Here is a diff from gimp-2.2.8-r1
- useflag gimpshop is added
- some infos to help users who want same shortcuts than photoshop

In this ebuild, I'm presumming that the patch (obtained with diff -rau, and compressed with bzip2) will be hosted in gentoo mirrors and not in rsync severs.
I'm not sure that this is ok to post a 240K file in bugzilla. You can find it here in plain text : http://www.zouaoui.org/gimpshop-2.2.8.patch , or here in compressed format : http://www.zouaoui.org/gimpshop-2.2.8.patch.bz2
Comment 19 Jakub Moc (RETIRED) gentoo-dev 2006-02-04 13:29:11 UTC
*** Bug 121591 has been marked as a duplicate of this bug. ***
Comment 20 Beech Horn 2006-02-08 23:32:11 UTC
Created attachment 79299 [details]
gimpshop-2.2.10.ebuild

Just finished compiling :D
Comment 21 mathe 2006-09-25 14:07:38 UTC
Created attachment 98065 [details]
gimpshop 2.2.11
Comment 22 mathe 2006-09-25 14:08:34 UTC
Created attachment 98066 [details, diff]
patch to libpng >=1.2.10
Comment 23 Jakub Moc (RETIRED) gentoo-dev 2006-12-09 01:27:31 UTC
*** Bug 157556 has been marked as a duplicate of this bug. ***
Comment 24 Roman 2008-01-21 11:12:45 UTC
I have few errors  with latest ebuild:

1. Help file url is not found here's the fix:

Change this:
P_HELP="gimp-help-2-0.9" #gimp-help-2-{version}
S_HELP="$WORKDIR/${P_HELP}"
SRC_URI="http://www.plasticbugs.com/blogimg/gimpshop-${PV}.tar.bz2
doc? ( mirror://gimp/help/testing/${P_HELP}.tar.gz )"
to:
P_HELP="gimp-help-2.4.0" #gimp-help-2-{version}
S_HELP="$WORKDIR/${P_HELP}"
SRC_URI="http://www.plasticbugs.com/blogimg/gimpshop-${PV}.tar.bz2
    doc? ( ftp://unix.hensa.ac.uk/sites/ftp.gimp.org/pub/gimp/help/${P_HELP}.tar.bz2 )"


2. I have an error on 67'th line when emerging this ebuild. I think it have a wrong directory name here change this:
 mv ${PORTAGE_TMPDIR}/portage/gimpshop-${PV}/work/gimp-${PV} ${PORTAGE_TMPDIR}/portage/gimpshop-${PV}/work/gimpshop-${PV}
to 
 mv ${PORTAGE_TMPDIR}/portage/media-gfx/gimpshop-${PV}/work/gimp-${PV} ${PORTAGE_TMPDIR}/portage/media-gfx/gimpshop-${PV}/work/gimpshop-${PV}


 At least it worked for me