https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: games-action/polymc-1.4.2-r2 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 814318 [details] build.log.xz build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: Index FAILED: Library FAILED: ModFolderModel FAILED: Task FAILED: polymc /var/tmp/portage/games-action/polymc-1.4.2-r2/work/PolyMC-1.4.2_build/launcher/Launcher_logic_autogen/F26Q4VW2FO/../../../../PolyMC-1.4.2/launcher/meta/VersionList.h:28:7: error: type ‘struct VersionList’ violates the C++ One Definition Rule [-Werror=odr]
Same with prismlauncher, fwiw.
ping
Does this only happen with PolyMC 1.4.2? Or does it also happen on PolyMC 6.1? If the latter, please file a bug on PolyMC upstream. Prism Launcher as well if it has it.
(In reply to Carson Rueter from comment #5) > Does this only happen with PolyMC 1.4.2? Or does it also happen on PolyMC > 6.1? > > If the latter, please file a bug on PolyMC upstream. Prism Launcher as well > if it has it. The ping was for the package maintainer to ideally do that. I've not checked the latest version myself.
(In reply to Sam James from comment #6) > (In reply to Carson Rueter from comment #5) > > Does this only happen with PolyMC 1.4.2? Or does it also happen on PolyMC > > 6.1? > > > > If the latter, please file a bug on PolyMC upstream. Prism Launcher as well > > if it has it. > > The ping was for the package maintainer to ideally do that. I've not checked > the latest version myself. Ok, I was pinged since I'm on the maintainers list for polyMC. This doesn't occur on normal builds but I'll we if it happens with an updated ebuild
Version 8.2 seems to be fine, not sure about the other versions.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2dad9dd76c2380c45c168a447a1742240d46e1dd commit 2dad9dd76c2380c45c168a447a1742240d46e1dd Author: Andrew Ammerlaan <andrewammerlaan@gentoo.org> AuthorDate: 2024-03-11 21:23:01 +0000 Commit: Andrew Ammerlaan <andrewammerlaan@gentoo.org> CommitDate: 2024-03-11 21:24:38 +0000 games-action/prismlauncher: add 8.2 Bug: https://bugs.gentoo.org/917072 Bug: https://bugs.gentoo.org/873142 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org> games-action/prismlauncher/Manifest | 1 + .../files/prismlauncher-8.2-openjdk21.patch | 44 ++++++ .../prismlauncher/prismlauncher-8.2.ebuild | 166 +++++++++++++++++++++ .../prismlauncher/prismlauncher-9999.ebuild | 18 ++- 4 files changed, 227 insertions(+), 2 deletions(-)
Ah, fixed by https://github.com/PrismLauncher/PrismLauncher/pull/374.
