2:31.44 error: expected one of `!` or `::`, found keyword `mod` 2:31.45 --> /tmp/portage/mail-client/thunderbird-102.2.2-r1/work/thunderbird-102.2.2/third_party/rust/packed_simd_2/src/lib.rs:347:7 2:31.45 | 2:31.45 347 | crate mod llvm { 2:31.45 | ^^^ expected one of `!` or `::` 2:31.46 error: could not compile `packed_simd_2` due to previous error Patch: https://github.com/rust-lang/packed_simd/commit/0d5887bec983381dd1bfce922ae25384dd4190fb Reproducible: Always
Created attachment 805090 [details] build.log
Created attachment 805093 [details] emerge --info
I am able to confirm build issue of Thunderbird using Rust =1.63.0. However, I am using =dev-lang/rust-bin-1.63.0 … so an epatch to the sources of Rust won't fix BDEPS in all cases in the wild. So I rather would limit thunderbird's BDEPS to <virtual/rust-1.63.0 until the upstream fix has been merged into a forthcoming version of Rust?
(In reply to Christian Bricart from comment #3) > I am able to confirm build issue of Thunderbird using Rust =1.63.0. > > However, I am using =dev-lang/rust-bin-1.63.0 … so an epatch to the sources > of Rust won't fix BDEPS in all cases in the wild. > > So I rather would limit thunderbird's BDEPS to <virtual/rust-1.63.0 until > the upstream fix has been merged into a forthcoming version of Rust? The patch is for Thunderbird, not Firefox.
Ah sorry for the noise, got confused because the patch originates from rust repo - now I spot it applies to thunderbird third party dir
Sigh, and here I was hoping Gentoo wouldn't get rust bumped before 102.3.0 landed. Upstream has indeed fixed the issue for rust-1.63.0 for the next releases.
Confirming. Seems to me the bug is fixed in packed_simd_2-0.38, but thunderbird-102 is using packed_simd_2-0.36 which has the older rust code crate mod llvm { crate use crate::codegen::llvm::*; } instead of the newer pub(crate) mod llvm { pub(crate) use crate::codegen::llvm::*; } That's with rust-1.63. Will add a patch if build finishes ...
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e6045d7ac594eace8fea77c0b2f62987b2fb7a2 commit 8e6045d7ac594eace8fea77c0b2f62987b2fb7a2 Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2022-09-15 06:09:28 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-09-15 06:09:28 +0000 mail-client/thunderbird: restrict rust dep <1.63 on 102 - new versions which supports rust-1.63 will be out in few days. Bug: https://bugs.gentoo.org/870088 Signed-off-by: Joonas Niilola <juippis@gentoo.org> mail-client/thunderbird/thunderbird-102.2.2-r1.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9397d07c5329a062eb63883d14018e143d6f6ba2 commit 9397d07c5329a062eb63883d14018e143d6f6ba2 Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2022-09-15 06:08:18 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-09-15 06:08:18 +0000 www-client/firefox: restrict rust to <1.63 on 102 - new versions which supports 1.63 will be out in few days. Bug: https://bugs.gentoo.org/870088 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/firefox/firefox-102.2.0.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
FWIW I think firefox-102 built with rust-1.63, as it has packed_simd_2-0.38, whereas thunderbird-102 has packed_simd_2-0.38. That's looking at the mozilla repositories for both. Also FF built for me.
thunderbird-102.3.0 built for me, rust-1.63.0-r1
Fixed in mail-client/thunderbird-102.3.0
