Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 866683 - dev-lang/php-8.0.22 fails to compile (lto): zend_jit_vm_helpers.c:38:34: error: global register variable follows a function definition
Summary: dev-lang/php-8.0.22 fails to compile (lto): zend_jit_vm_helpers.c:38:34: erro...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PHP Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-08-26 11:33 UTC by Agostino Sarubbo
Modified: 2023-09-07 10:42 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,639.07 KB, text/plain)
2022-08-26 11:33 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-26 11:33:22 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-lang/php-8.0.22 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-26 11:33:26 UTC
Created attachment 801085 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2023-08-22 17:36:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0f5d2d85b5bdfec98186f218c5f355e057d5e017

commit 0f5d2d85b5bdfec98186f218c5f355e057d5e017
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2023-08-22 16:52:27 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2023-08-22 17:35:54 +0000

    dev-lang/php: fix LTO build (8.0 and 8.1 series)
    
    Closes: https://bugs.gentoo.org/866683
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 dev-lang/php/php-8.0.30.ebuild | 5 +++++
 dev-lang/php/php-8.1.21.ebuild | 5 +++++
 2 files changed, 10 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d419a789867813ca3c8dbd7693152c6ec162796c

commit d419a789867813ca3c8dbd7693152c6ec162796c
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2023-08-22 16:49:33 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2023-08-22 17:35:42 +0000

    dev-lang/php: add 8.2.9, drop 8.2.8-r2
    
     * New upstream security release.
     * Bring back USE=ipv6. Despite what pkgcheck thinks, this entails
       significant code changes.
     * Fix LTO build (bug 866683).
    
    Bug: https://bugs.gentoo.org/866683
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 dev-lang/php/Manifest                                  | 2 +-
 dev-lang/php/{php-8.2.8-r2.ebuild => php-8.2.9.ebuild} | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)