Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 865265 - app-admin/calamares-3.2.60 fails tests
Summary: app-admin/calamares-3.2.60 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-15 18:22 UTC by Agostino Sarubbo
Modified: 2024-03-22 20:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,52.28 KB, application/x-xz)
2022-08-15 18:22 UTC, Agostino Sarubbo
Details
1-LastTest.log (1-LastTest.log,264.06 KB, text/plain)
2022-08-15 18:22 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-15 18:22:55 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-admin/calamares-3.2.60 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-15 18:22:58 UTC
Created attachment 799759 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2022-08-15 18:22:59 UTC
Created attachment 799761 [details]
1-LastTest.log

1-LastTest.log
Comment 3 Agostino Sarubbo gentoo-dev 2022-08-15 18:23:01 UTC
Error(s) that match a know pattern:


	 15 - configure-displaymanager-greetd (Failed)
  Could not find a package configuration file provided by "AppStreamQt" with
  Could not find a package configuration file provided by "KF5Plasma"
-- Could NOT find Qt5Location (missing: Qt5Location_DIR)
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-15 06:54:24 UTC
15/123 Testing: configure-displaymanager-greetd
15/123 Test: configure-displaymanager-greetd
Command: "/usr/bin/env" "PYTHONPATH=.:" "python3" "/var/tmp/portage/app-admin/calamares-3.2.60/work/calamares-3.2.60/src/modules/displaymanager/tests/test-dm-greetd.py"
Directory: /var/tmp/portage/app-admin/calamares-3.2.60/work/calamares-3.2.60_build
"configure-displaymanager-greetd" start time: Aug 14 02:09 CEST
Output:
----------------------------------------------------------
QCoreApplication::applicationDirPath: Please instantiate the QApplication object first
Traceback (most recent call last):
  File "/var/tmp/portage/app-admin/calamares-3.2.60/work/calamares-3.2.60/src/modules/displaymanager/tests/test-dm-greetd.py", line 22, in <module>
    d.set_autologin("d", True, default_desktop_environment)
  File "/var/tmp/portage/app-admin/calamares-3.2.60/work/calamares-3.2.60_build/src/modules/displaymanager/main.py", line 905, in set_autologin
    self.config_load()
  File "/var/tmp/portage/app-admin/calamares-3.2.60/work/calamares-3.2.60_build/src/modules/displaymanager/main.py", line 855, in config_load
    import toml
ModuleNotFoundError: No module named 'toml'
<end of output>
Test time =   0.13 sec
----------------------------------------------------------
Test Failed.
"configure-displaymanager-greetd" end time: Aug 14 02:09 CEST
"configure-displaymanager-greetd" time elapsed: 00:00:00
----------------------------------------------------------

not LTO
Comment 5 Larry the Git Cow gentoo-dev 2024-03-22 20:55:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=618852ed64e5fbfc546bee4444c7663164646eac

commit 618852ed64e5fbfc546bee4444c7663164646eac
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2024-03-22 20:53:17 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2024-03-22 20:54:55 +0000

    app-admin/calamares: add 3.3.5
    
    - adds (maksed) qt6 support
    - adds gentoo branding (read from /etc/os-release)
    - drop tests requiring toml
    
    Closes: https://bugs.gentoo.org/865265
    Closes: https://bugs.gentoo.org/925724
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 app-admin/calamares/Manifest                       |   1 +
 app-admin/calamares/calamares-3.3.5.ebuild         | 167 ++++++++++++++
 .../calamares/files/calamares-gentoo-branding.desc | 239 +++++++++++++++++++++
 profiles/base/package.use.mask                     |   4 +
 4 files changed, 411 insertions(+)