Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 862672 - sci-libs/caffe2-1.12.0 fails to compile (lto): moments_utils.h:76: error: type of c_vecs does not match original declaration [-Werror=lto-type-mismatch]
Summary: sci-libs/caffe2-1.12.0 fails to compile (lto): moments_utils.h:76: error: typ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tupone Alfredo
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-08-01 07:41 UTC by Agostino Sarubbo
Modified: 2022-08-04 08:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,55.06 KB, application/x-xz)
2022-08-01 07:41 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-01 07:41:21 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/caffe2-1.12.0 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-01 07:41:24 UTC
Created attachment 796414 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2022-08-01 07:41:26 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


-- Caffe2: Cannot find glog automatically. Using legacy find.
-- Could NOT find Numa (missing: Numa_INCLUDE_DIR Numa_LIBRARIES) 
-- Could not find CUDA with FP16 support, compiling without torch.CudaHalfTensor
-- Could not find hardware support for NEON on this machine.
FAILED: lib/libtorch_cpu.so 
fatal: not a git repository (or any parent up to mount point /var/tmp)
/var/tmp/portage/sci-libs/caffe2-1.12.0/work/pytorch-1.12.0/aten/src/ATen/native/cpu/moments_utils.h:76: error: type of ‘c_vecs’ does not match original declaration [-Werror=lto-type-mismatch]
Comment 3 Tupone Alfredo gentoo-dev 2022-08-03 10:36:50 UTC
Reported upstream:
https://github.com/pytorch/pytorch/issues/82710
Comment 4 Larry the Git Cow gentoo-dev 2022-08-04 08:00:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7dd94587118b7333242a46b4f97c22ed69d6fc0d

commit 7dd94587118b7333242a46b4f97c22ed69d6fc0d
Author:     Alfredo Tupone <tupone@gentoo.org>
AuthorDate: 2022-08-04 07:59:56 +0000
Commit:     Alfredo Tupone <tupone@gentoo.org>
CommitDate: 2022-08-04 07:59:56 +0000

    sci-libs/caffe2: filter lto
    
    Closes: https://bugs.gentoo.org/862672
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Alfredo Tupone <tupone@gentoo.org>

 sci-libs/caffe2/caffe2-1.11.0-r2.ebuild | 2 +-
 sci-libs/caffe2/caffe2-1.12.0.ebuild    | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)