Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 861608 - net-misc/dhcdrop-0.5-r1 fails to compile (lto): <artificial>:(.text+0x204e): undefined reference to rand_ether_addr
Summary: net-misc/dhcdrop-0.5-r1 fails to compile (lto): <artificial>:(.text+0x204e): ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Vladimir Pavljuchenkov (SpiderX)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-28 07:03 UTC by Agostino Sarubbo
Modified: 2022-08-23 07:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,53.13 KB, text/plain)
2022-07-28 07:03 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-28 07:03:55 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/dhcdrop-0.5-r1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-28 07:03:57 UTC
Created attachment 795110 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-28 07:03:59 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


/usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/../../../../x86_64-pc-linux-gnu/bin/ld: <artificial>:(.text.startup+0x1630): undefined reference to `print_ether'
<artificial>:(.text+0x204e): undefined reference to `rand_ether_addr'
<artificial>:(.text.startup+0x1008): undefined reference to `rand_ether_addr'
collect2: error: ld returned 1 exit status
Comment 3 Larry the Git Cow gentoo-dev 2022-08-23 07:05:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1356604f1f11718271781b70014347f1cafff82e

commit 1356604f1f11718271781b70014347f1cafff82e
Author:     Sergey Popov <pinkbyte@gentoo.org>
AuthorDate: 2022-08-23 07:02:49 +0000
Commit:     Sergey Popov <pinkbyte@gentoo.org>
CommitDate: 2022-08-23 07:03:01 +0000

    net-misc/dhcdrop: bump EAPI to 8, fix building with -flto
    
    Reported-by: Agostino Sarubbo <ago@gentoo.org>
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Vladimir Pavljuchenkov <spiderx@spiderx.dp.ua>
    Signed-off-by: Sergey Popov <pinkbyte@gentoo.org>
    Closes: https://bugs.gentoo.org/861608
    Closes: https://github.com/gentoo/gentoo/pull/26942

 net-misc/dhcdrop/dhcdrop-0.5-r1.ebuild       | 11 +++++++---
 net-misc/dhcdrop/files/dhcdrop-0.5-lto.patch | 33 ++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 3 deletions(-)