Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 861602 - net-misc/bgpq3-0.1.36 fails to compile (lto): bgpq3_printer.c:1057:53: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Summary: net-misc/bgpq3-0.1.36 fails to compile (lto): bgpq3_printer.c:1057:53: error:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jaco Kroon
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 865725
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-28 06:57 UTC by Agostino Sarubbo
Modified: 2022-09-29 08:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,47.75 KB, text/plain)
2022-07-28 06:57 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-28 06:57:44 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/bgpq3-0.1.36 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-28 06:57:46 UTC
Created attachment 795104 [details]
build.log

build log and emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-18 21:51:47 UTC
commit e677cbf834ed137136227d650a9acabef408cc8c (HEAD -> master, origin/master, origin/HEAD)
Author: Sam James <sam@gentoo.org>
Date:   Thu Aug 18 22:49:30 2022 +0100

    net-misc/bgpq4: drop new keywords except for ~amd64, drop src_install

    - We'll file for new rekeywording to copy bgpq3 keywords shortly
    - Drop unnecessary src_install (Makefile works fine)

    Signed-off-by: Sam James <sam@gentoo.org>

commit 0849e9d735d6fa060b41baac668eee399a2829c9
Author: Jaco Kroon <jaco@uls.co.za>
Date:   Thu Aug 18 23:41:15 2022 +0200

    net-misc/bgpq4: replacement for bgpq3

    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Closes: https://github.com/gentoo/gentoo/pull/26918
    Signed-off-by: Sam James <sam@gentoo.org>

We're going to pursue 4 instead.
Comment 3 Larry the Git Cow gentoo-dev 2022-08-23 08:59:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c2a243adb70e8200393c6ab79757b6f59cea9d41

commit c2a243adb70e8200393c6ab79757b6f59cea9d41
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2022-08-19 07:39:50 +0000
Commit:     Matthew Smith <matthew@gentoo.org>
CommitDate: 2022-08-23 08:47:53 +0000

    profiles: last rite bgpq3
    
    Bug:  https://bugs.gentoo.org/show_bug.cgi?id=861602
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Closes: https://github.com/gentoo/gentoo/pull/26923
    Signed-off-by: Matthew Smith <matthew@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2022-09-29 08:01:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d18737cd3c78aff1dce6b81979ccd5cc9f8e63e

commit 0d18737cd3c78aff1dce6b81979ccd5cc9f8e63e
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2022-09-29 08:01:26 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2022-09-29 08:01:34 +0000

    net-misc/bgpq3: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/861602
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 net-misc/bgpq3/Manifest            |  2 --
 net-misc/bgpq3/bgpq3-0.1.35.ebuild | 34 ----------------------------------
 net-misc/bgpq3/bgpq3-0.1.36.ebuild | 34 ----------------------------------
 net-misc/bgpq3/metadata.xml        | 29 -----------------------------
 profiles/package.mask              |  6 ------
 5 files changed, 105 deletions(-)